Skip to content
This repository has been archived by the owner on Oct 1, 2024. It is now read-only.

Add build runtime and remove outdated config #1829

Merged
merged 5 commits into from
Apr 9, 2021
Merged

Conversation

BPScott
Copy link
Member

@BPScott BPScott commented Apr 9, 2021

Description

While investigating rollup builds I found some polish that could be applied to our current process.

  • Sewing-kit has a concept of "runtimes" that allows you to specify what a project can be compiled for. We weren't using this. While the buildFlexibleOutputs plugin doesn't leverage this too heavily, the rollup plugin can be configured to skip builds for irrelevant runtimes. e.g. there's no point doing an esnext build for a package like koa-liveness-ping that is node-only.
  • Packages still had a build script referencing tsc - We don't use that anymore so it can be removed.
  • Packages had a dependency on tslib - This is no longer the case as we don't compile with tsc anymore.

This PR:

  • Adds runtimes to each package's sewing-kit.config.ts
  • Removes all dependencies on tslib in project package.json files
  • Removes all builds scripts using tsc in project package.json files

Type of change

  • EVERY PACKAGE Patch: Bug (non-breaking change which fixes an issue)

Checklist

  • I have added a changelog entry, prefixed by the type of change noted above (Documentation fix and Test update does not need a changelog as we do not publish new version)

@BPScott BPScott requested a review from a team April 9, 2021 00:36
@kaelig
Copy link
Contributor

kaelig commented Apr 9, 2021

👋 Please run:

git pull origin main --rebase && git push origin sknext-build-tidyups --force

to get the latest changes and fix the failing test, apologies for the inconvenience.

@BPScott BPScott force-pushed the sknext-build-tidyups branch from 7cccb87 to 2302602 Compare April 9, 2021 04:39
Copy link
Contributor

@ismail-syed ismail-syed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome clean up work! 🎉

@BPScott BPScott force-pushed the sknext-build-tidyups branch from cd0c78a to fbccf2c Compare April 9, 2021 21:34
@BPScott BPScott merged commit bd5934d into main Apr 9, 2021
@BPScott BPScott deleted the sknext-build-tidyups branch April 9, 2021 21:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants