Drop node 12 support, remove wildcard exports, update browser support #2277

vsumner · 2022-05-18T19:23:36Z

Description

Node 12 is not longer supported.

This PR drops support to unblock updating dependencies that no longer support 12.
It also includes the following breaking changes

remove wildcard export
update browser support

I also removed the node 12 tests.

Fixes (issue #)

Type of change

Patch: Bug (non-breaking change which fixes an issue)
Minor: New feature (non-breaking change which adds functionality)
Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

I have added a changelog entry, prefixed by the type of change noted above (Documentation fix and Test update does not need a changelog as we do not publish new version)

BPScott · 2022-05-18T19:43:17Z

For node versions, as we're making breaking changes we should ensure we limit to versions that fully support the exports field and generally "when esmodules was marked as stable" - this was in v14.17.0, v16.0.0. v15 doesn't consider modules as stable and it is EOL so I don't think we should bother supporting it.

The engines field range should be ^14.17.0 || >=16.0.0. (you can see this syntax in use in loom's packages). We can get more aggressive to only support from when long-term-support was activated (i.e. ^14.17.0 || >=16.13.0) if desired, but I don't think that's needed.

We should also take this opportunity as chance to remove the "./*": "./*" export mapping and finally proclaim "The only allowed imports are the ones specified in the exports list"

While we're making breaking changes to version support, we should also bump the browser support versions per #1970. It'd be nice to reevaluate the polyfills stuff t-o but I think we can punt the polyfills to a later major version.

BPScott · 2022-05-18T20:28:17Z

After this gets merged, I'd want to merge #2231 before cutting the new major versions - that faker update is technically a breaking change as we reexport faker.

Rolling this out in web is going to require a bit of work, as transitive dependencies shall mean duplication. What we can do is:

update web to use the new major versions, adding resolutions to force the new major version is used by transitive dependencies.
Make PRs to update all the transitive dependencies that rely on older versions of the quilt packages, and badger those teams to get them into web (e.g. online-store-ui depends upon @shopify/react-hooks and @shopify/css-utilities).
As updated dependencies make their way into web we remove the resolutions.

caution-tape-bot · 2022-05-18T20:56:11Z

👋 It looks like you're updating JavaScript packages that are known
to cause problems when duplicated.

You can deduplicate them with the yarn-deduplicate utility:

npx yarn-deduplicate --packages graphql react react-dom webpack
npx yarn-deduplicate --scopes @shopify @apollo

If running these commands doesn't produce a change in your yarn.lock file,
you didn't have duplications in these packages and can carry on.

A duplicate React version may cause an invalid hook call warning.

React context providers usually use module-scoped globals as their
default context values. Multiple versions of such packages will yield
multiple global instances, resulting in oblique runtime errors.

atesgoral · 2022-05-18T20:59:13Z

.github/workflows/node-ci.yml

@@ -17,7 +17,7 @@ jobs:
        # output to 14.x and 16.x, so for now lock to the last version in 14
        # and 16 before the ICU change.
        # Once we drop support for node 12 we can consider using 14.x and 16.x


Suggested change

# Once we drop support for node 12 we can consider using 14.x and 16.x

Or too soon?

I didn't want to add too much overhead to this PR with too many changes. I thought it could be a follow up.

This is going to result in needing to update some expected test output, so +1 to a separate PR

BPScott

Ran a build and compared it against master and confirmed that we're now seeing a wild reduction in babel helpers required - no more needing to transform object spread or async/await syntaxes is huge 🎉

find packages -name _rollupPluginBabelHelpers.mjs now shows only 3 packages that need syntax transforms!

I dropped a comment inline about updating the text of the changelog entry. Update that, and update shipit/production.yml to remove the reference to node-tests (12.22) and then this is good to go.

Before this is released as a new major version, I'd want to rebase and merge #2231, and update the ci node versions so they go back to 14.x and 16.x, and use 16.14 locally. (see #2171 for context)

BPScott · 2022-05-18T21:13:56Z

packages/address-consts/CHANGELOG.md

+
+### Breaking Change
+
+- Drop support for node 12. Remove wildcard export. Update `@shopify/browserslist-config`. [[#2277](https://github.com/Shopify/quilt/pull/2277)]


Consumers don't care about the change to @shopify/browserslist-config, they care about the impact that it has, What do you think to using this as the changelog line?

Suggested change

- Drop support for node 12. Remove wildcard export. Update `@shopify/browserslist-config`. [[#2277](https://github.com/Shopify/quilt/pull/2277)]

- Drop support for node 12 and Safari 10, 11 and 12. Remove wildcard export in exports field. [[#2277](https://github.com/Shopify/quilt/pull/2277)]

BPScott · 2022-05-18T21:14:35Z

.github/workflows/node-ci.yml

@@ -17,7 +17,7 @@ jobs:
        # output to 14.x and 16.x, so for now lock to the last version in 14
        # and 16 before the ICU change.
        # Once we drop support for node 12 we can consider using 14.x and 16.x


This is going to result in needing to update some expected test output, so +1 to a separate PR

BPScott · 2022-05-18T21:30:05Z

Oh! you'll need to update shipit.production.yml to remove the reference to node-tests (12.22)

vsumner · 2022-05-18T22:01:57Z

Oh! you'll need to update shipit.production.yml to remove the reference to node-tests (12.22)

I did already.

BPScott

🎉

vsumner added 2 commits May 18, 2022 15:22

Drop node 12

0d7af76

use 14.18.0

bb51bb6

vsumner added 2 commits May 18, 2022 15:49

update targets

838984c

Remove wildcard exports

8c5c895

vsumner added 2 commits May 18, 2022 16:32

fix verion range

7a508fc

Fix test

2b014f2

vsumner changed the title ~~[WIP] Drop node 12 support~~ [WIP] Drop node 12 support, remove wildcard exports, update browser support May 18, 2022

vsumner added 2 commits May 18, 2022 16:51

update browserslist-config

e417491

Update the changelogs

e1df469

vsumner changed the title ~~[WIP] Drop node 12 support, remove wildcard exports, update browser support~~ Drop node 12 support, remove wildcard exports, update browser support May 18, 2022

vsumner marked this pull request as ready for review May 18, 2022 20:55

vsumner requested a review from a team as a code owner May 18, 2022 20:55

vsumner requested a review from znja May 18, 2022 20:55

BPScott self-requested a review May 18, 2022 20:59

atesgoral reviewed May 18, 2022

View reviewed changes

BPScott reviewed May 18, 2022

View reviewed changes

Update the changelogs

706190a

BPScott approved these changes May 18, 2022

View reviewed changes

vsumner merged commit 9fccd75 into main May 19, 2022

vsumner deleted the drop-node-12 branch May 19, 2022 13:14

BPScott mentioned this pull request May 19, 2022

Update faker-js/faker to v6 #2231

Merged

shopify-shipit bot temporarily deployed to production-js May 19, 2022 18:00 Inactive

BPScott mentioned this pull request May 20, 2022

Review polyfills based on updated target versions #1970

Closed

joshbeckman mentioned this pull request May 20, 2022

Upgrade of react-network to 5.0.0 causing render error #2285

Closed

4 tasks

shopify-shipit bot temporarily deployed to beta-js May 25, 2022 20:52 Inactive

shopify-shipit bot temporarily deployed to production-gem June 21, 2022 14:45 Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Drop node 12 support, remove wildcard exports, update browser support #2277

Drop node 12 support, remove wildcard exports, update browser support #2277

vsumner commented May 18, 2022 •

edited

Loading

BPScott commented May 18, 2022 •

edited

Loading

BPScott commented May 18, 2022 •

edited

Loading

caution-tape-bot bot commented May 18, 2022

atesgoral May 18, 2022

atesgoral May 18, 2022

vsumner May 18, 2022 •

edited

Loading

BPScott May 18, 2022

BPScott left a comment •

edited

Loading

BPScott May 18, 2022

BPScott May 18, 2022

BPScott commented May 18, 2022

vsumner commented May 18, 2022

BPScott left a comment


		### Breaking Change

		- Drop support for node 12. Remove wildcard export. Update `@shopify/browserslist-config`. [[#2277](https://github.com/Shopify/quilt/pull/2277)]

	- Drop support for node 12. Remove wildcard export. Update `@shopify/browserslist-config`. [[#2277](https://github.com/Shopify/quilt/pull/2277)]
	- Drop support for node 12 and Safari 10, 11 and 12. Remove wildcard export in exports field. [[#2277](https://github.com/Shopify/quilt/pull/2277)]

Drop node 12 support, remove wildcard exports, update browser support #2277

Drop node 12 support, remove wildcard exports, update browser support #2277

Conversation

vsumner commented May 18, 2022 • edited Loading

Description

Type of change

Checklist

BPScott commented May 18, 2022 • edited Loading

BPScott commented May 18, 2022 • edited Loading

caution-tape-bot bot commented May 18, 2022

atesgoral May 18, 2022

Choose a reason for hiding this comment

atesgoral May 18, 2022

Choose a reason for hiding this comment

vsumner May 18, 2022 • edited Loading

Choose a reason for hiding this comment

BPScott May 18, 2022

Choose a reason for hiding this comment

BPScott left a comment • edited Loading

Choose a reason for hiding this comment

BPScott May 18, 2022

Choose a reason for hiding this comment

BPScott May 18, 2022

Choose a reason for hiding this comment

BPScott commented May 18, 2022

vsumner commented May 18, 2022

BPScott left a comment

Choose a reason for hiding this comment

vsumner commented May 18, 2022 •

edited

Loading

BPScott commented May 18, 2022 •

edited

Loading

BPScott commented May 18, 2022 •

edited

Loading

vsumner May 18, 2022 •

edited

Loading

BPScott left a comment •

edited

Loading