Skip to content
This repository has been archived by the owner on Oct 1, 2024. It is now read-only.

Drop node 12 support, remove wildcard exports, update browser support #2277

Merged
merged 9 commits into from
May 19, 2022
Merged

Drop node 12 support, remove wildcard exports, update browser support #2277

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
0d7af76
Drop node 12
vsumner May 18, 2022
bb51bb6
use 14.18.0
vsumner May 18, 2022
838984c
update targets
vsumner May 18, 2022
8c5c895
Remove wildcard exports
vsumner May 18, 2022
7a508fc
fix verion range
vsumner May 18, 2022
2b014f2
Fix test
vsumner May 18, 2022
e417491
update browserslist-config
vsumner May 18, 2022
e1df469
Update the changelogs
vsumner May 18, 2022
706190a
Update the changelogs
vsumner May 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/node-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
# output to 14.x and 16.x, so for now lock to the last version in 14
# and 16 before the ICU change.
# Once we drop support for node 12 we can consider using 14.x and 16.x
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Once we drop support for node 12 we can consider using 14.x and 16.x

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or too soon?

Copy link
Collaborator Author

@vsumner vsumner May 18, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't want to add too much overhead to this PR with too many changes. I thought it could be a follow up.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to result in needing to update some expected test output, so +1 to a separate PR

node-version: ['12.22', '14.18', '16.13']
node-version: ['14.18', '16.13']
timeout-minutes: 15

steps:
Expand Down
4 changes: 2 additions & 2 deletions config/loom/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ export function quiltPackage({
const polyfillOptions = polyfill ? {} : {useBuiltIns: false, corejs: false};

const targets = isIsomorphic
? 'extends @shopify/browserslist-config, node 12.14.0'
: 'node 12.14.0';
? 'extends @shopify/browserslist-config, node 14.17.0'
: 'node 14.17.0';

return createComposedProjectPlugin<Package>('Quilt.Package', [
buildLibrary({
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
"@faker-js/faker": "^5.5.3",
"@shopify/app-bridge": "^2.0.3",
"@shopify/babel-preset": "^24.1.4",
"@shopify/browserslist-config": "^2.2.4",
"@shopify/browserslist-config": "^3.0.0",
"@shopify/eslint-plugin": "^41.1.0",
"@shopify/loom": "^1.0.1",
"@shopify/loom-cli": "^1.0.1",
Expand Down
6 changes: 5 additions & 1 deletion packages/address-consts/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,11 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

<!-- ## Unreleased -->
## Unreleased

### Breaking Change

- Drop support for node 12. Remove wildcard export. Update `@shopify/browserslist-config`. [[#2277](https://github.com/Shopify/quilt/pull/2277)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consumers don't care about the change to @shopify/browserslist-config, they care about the impact that it has, What do you think to using this as the changelog line?

Suggested change
- Drop support for node 12. Remove wildcard export. Update `@shopify/browserslist-config`. [[#2277](https://github.com/Shopify/quilt/pull/2277)]
- Drop support for node 12 and Safari 10, 11 and 12. Remove wildcard export in exports field. [[#2277](https://github.com/Shopify/quilt/pull/2277)]


## 3.0.10 - 2022-03-09

Expand Down
5 changes: 2 additions & 3 deletions packages/address-consts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
},
"homepage": "https://github.com/Shopify/quilt/blob/main/packages/address-consts/README.md",
"engines": {
"node": ">=12.14.0"
"node": "^14.17.0 || >=16.0.0"
},
"files": [
"build/",
Expand All @@ -38,7 +38,6 @@
"esnext": "./index.esnext",
"import": "./index.mjs",
"require": "./index.js"
},
"./*": "./*"
}
}
}
6 changes: 5 additions & 1 deletion packages/address-mocks/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,11 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

<!-- ## Unreleased -->
## Unreleased

### Breaking Change

- Drop support for node 12. Remove wildcard export. Update `@shopify/browserslist-config`. [[#2277](https://github.com/Shopify/quilt/pull/2277)]

## 2.1.0 - 2022-03-10

Expand Down
5 changes: 2 additions & 3 deletions packages/address-mocks/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
},
"homepage": "https://github.com/Shopify/quilt/blob/main/packages/address-mocks/README.md",
"engines": {
"node": ">=12.14.0"
"node": "^14.17.0 || >=16.0.0"
},
"devDependencies": {
"@shopify/jest-dom-mocks": "^2.11.5"
Expand All @@ -45,7 +45,6 @@
"esnext": "./index.esnext",
"import": "./index.mjs",
"require": "./index.js"
},
"./*": "./*"
}
}
}
6 changes: 5 additions & 1 deletion packages/address/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,11 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

<!-- ## Unreleased -->
## Unreleased

### Breaking Change

- Drop support for node 12. Remove wildcard export. Update `@shopify/browserslist-config`. [[#2277](https://github.com/Shopify/quilt/pull/2277)]

## 3.2.0 - 2022-03-10

Expand Down
5 changes: 2 additions & 3 deletions packages/address/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
},
"homepage": "https://github.com/Shopify/quilt/blob/main/packages/address/README.md",
"engines": {
"node": ">=12.14.0"
"node": "^14.17.0 || >=16.0.0"
},
"devDependencies": {
"@shopify/address-mocks": "^2.1.0",
Expand All @@ -45,7 +45,6 @@
"esnext": "./index.esnext",
"import": "./index.mjs",
"require": "./index.js"
},
"./*": "./*"
}
}
}
6 changes: 5 additions & 1 deletion packages/admin-graphql-api-utilities/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,11 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

<!-- ## Unreleased -->
## Unreleased

### Breaking Change

- Drop support for node 12. Remove wildcard export. Update `@shopify/browserslist-config`. [[#2277](https://github.com/Shopify/quilt/pull/2277)]

## 1.0.9 - 2022-03-09

Expand Down
5 changes: 2 additions & 3 deletions packages/admin-graphql-api-utilities/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
},
"homepage": "https://github.com/Shopify/quilt/blob/main/packages/admin-graphql-api-utilities/README.md",
"engines": {
"node": ">=12.14.0"
"node": "^14.17.0 || >=16.0.0"
},
"sideEffects": false,
"files": [
Expand All @@ -38,7 +38,6 @@
"esnext": "./index.esnext",
"import": "./index.mjs",
"require": "./index.js"
},
"./*": "./*"
}
}
}
6 changes: 5 additions & 1 deletion packages/ast-utilities/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,11 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

<!-- ## Unreleased -->
## Unreleased

### Breaking Change

- Drop support for node 12. Remove wildcard export. Update `@shopify/browserslist-config`. [[#2277](https://github.com/Shopify/quilt/pull/2277)]

## 1.3.4 - 2022-03-09

Expand Down
5 changes: 2 additions & 3 deletions packages/ast-utilities/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
},
"homepage": "https://github.com/Shopify/quilt/blob/main/packages/ast-utilities/README.md",
"engines": {
"node": ">=12.14.0"
"node": "^14.17.0 || >=16.0.0"
},
"devDependencies": {
"@babel/core": ">=7.0.0",
Expand Down Expand Up @@ -82,7 +82,6 @@
"esnext": "./index.esnext",
"import": "./index.mjs",
"require": "./index.js"
},
"./*": "./*"
}
}
}
6 changes: 5 additions & 1 deletion packages/async/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,11 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

<!-- ## Unreleased -->
## Unreleased

### Breaking Change

- Drop support for node 12. Remove wildcard export. Update `@shopify/browserslist-config`. [[#2277](https://github.com/Shopify/quilt/pull/2277)]

## 3.1.5 - 2022-03-09

Expand Down
5 changes: 2 additions & 3 deletions packages/async/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
},
"homepage": "https://github.com/Shopify/quilt/blob/main/packages/async/README.md",
"engines": {
"node": ">=12.14.0"
"node": "^14.17.0 || >=16.0.0"
},
"devDependencies": {
"@babel/core": ">=7.0.0",
Expand Down Expand Up @@ -57,7 +57,6 @@
"esnext": "./index.esnext",
"import": "./index.mjs",
"require": "./index.js"
},
"./*": "./*"
}
}
}
6 changes: 5 additions & 1 deletion packages/browser/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,11 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

<!-- ## Unreleased -->
## Unreleased

### Breaking Change

- Drop support for node 12. Remove wildcard export. Update `@shopify/browserslist-config`. [[#2277](https://github.com/Shopify/quilt/pull/2277)]

## 2.0.9 - 2022-03-09

Expand Down
5 changes: 2 additions & 3 deletions packages/browser/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
},
"homepage": "https://github.com/Shopify/quilt/blob/main/packages/browser/README.md",
"engines": {
"node": ">=12.14.0"
"node": "^14.17.0 || >=16.0.0"
},
"files": [
"build/",
Expand All @@ -41,7 +41,6 @@
"esnext": "./index.esnext",
"import": "./index.mjs",
"require": "./index.js"
},
"./*": "./*"
}
}
}
6 changes: 5 additions & 1 deletion packages/csrf-token-fetcher/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,11 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

<!-- ## Unreleased -->
## Unreleased

### Breaking Change

- Drop support for node 12. Remove wildcard export. Update `@shopify/browserslist-config`. [[#2277](https://github.com/Shopify/quilt/pull/2277)]

## 1.0.8 - 2022-03-09

Expand Down
5 changes: 2 additions & 3 deletions packages/csrf-token-fetcher/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
},
"homepage": "https://github.com/Shopify/quilt/blob/main/packages/csrf-token-fetcher/README.md",
"engines": {
"node": ">=12.14.0"
"node": "^14.17.0 || >=16.0.0"
},
"files": [
"build/",
Expand All @@ -38,7 +38,6 @@
"esnext": "./index.esnext",
"import": "./index.mjs",
"require": "./index.js"
},
"./*": "./*"
}
}
}
6 changes: 5 additions & 1 deletion packages/css-utilities/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,11 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

<!-- ## Unreleased -->
## Unreleased

### Breaking Change

- Drop support for node 12. Remove wildcard export. Update `@shopify/browserslist-config`. [[#2277](https://github.com/Shopify/quilt/pull/2277)]

## 2.0.9 - 2022-03-09

Expand Down
5 changes: 2 additions & 3 deletions packages/css-utilities/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
},
"homepage": "https://github.com/Shopify/quilt/blob/main/packages/css-utilities/README.md",
"engines": {
"node": ">=12.14.0"
"node": "^14.17.0 || >=16.0.0"
},
"dependencies": {
"classnames": "^2.3.1"
Expand All @@ -41,7 +41,6 @@
"esnext": "./index.esnext",
"import": "./index.mjs",
"require": "./index.js"
},
"./*": "./*"
}
}
}
6 changes: 5 additions & 1 deletion packages/dates/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,11 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

<!-- ## Unreleased -->
## Unreleased

### Breaking Change

- Drop support for node 12. Remove wildcard export. Update `@shopify/browserslist-config`. [[#2277](https://github.com/Shopify/quilt/pull/2277)]

## 1.1.5 - 2022-03-09

Expand Down
5 changes: 2 additions & 3 deletions packages/dates/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
},
"homepage": "https://github.com/Shopify/quilt/blob/main/packages/dates/README.md",
"engines": {
"node": ">=12.14.0"
"node": "^14.17.0 || >=16.0.0"
},
"dependencies": {
"@shopify/decorators": "^2.0.8"
Expand All @@ -44,7 +44,6 @@
"esnext": "./index.esnext",
"import": "./index.mjs",
"require": "./index.js"
},
"./*": "./*"
}
}
}
6 changes: 5 additions & 1 deletion packages/decorators/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,11 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

<!-- ## Unreleased -->
## Unreleased

### Breaking Change

- Drop support for node 12. Remove wildcard export. Update `@shopify/browserslist-config`. [[#2277](https://github.com/Shopify/quilt/pull/2277)]

## 2.0.8 - 2022-03-09

Expand Down
5 changes: 2 additions & 3 deletions packages/decorators/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
},
"homepage": "https://github.com/Shopify/quilt/blob/main/packages/decorators/README.md",
"engines": {
"node": ">=12.14.0"
"node": "^14.17.0 || >=16.0.0"
},
"files": [
"build/",
Expand All @@ -41,7 +41,6 @@
"esnext": "./index.esnext",
"import": "./index.mjs",
"require": "./index.js"
},
"./*": "./*"
}
}
}
6 changes: 5 additions & 1 deletion packages/function-enhancers/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,11 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

<!-- ## Unreleased -->
## Unreleased

### Breaking Change

- Drop support for node 12. Remove wildcard export. Update `@shopify/browserslist-config`. [[#2277](https://github.com/Shopify/quilt/pull/2277)]

## 2.0.8 - 2022-03-09

Expand Down
Loading