Merge pull request #269 from Shopify/emily/filter-versions-test

Change the `FilterVersions` rewriter tests to use the `filter_versions!` method
Shopify · Feb 23, 2024 · fd05e9b · fd05e9b
2 parents 0ad3556 + 55cdd73
commit fd05e9b
Showing 1 changed file with 12 additions and 12 deletions.
diff --git a/test/rbi/rewriters/filter_versions_test.rb b/test/rbi/rewriters/filter_versions_test.rb
@@ -36,7 +36,7 @@ class Buzz; end
 
       tree = Parser.parse_string(rbi)
 
-      Rewriters::FilterVersions.filter(tree, Gem::Version.new("0.4.0"))
+      tree.filter_versions!(Gem::Version.new("0.4.0"))
       assert_equal(<<~RBI, tree.string)
         # @version < 1.0.0
         class Foo; end
@@ -60,7 +60,7 @@ class Buzz; end
 
       tree = Parser.parse_string(rbi)
 
-      Rewriters::FilterVersions.filter(tree, Gem::Version.new("0.4.0"))
+      tree.filter_versions!(Gem::Version.new("0.4.0"))
       assert_equal(<<~RBI, tree.string)
         # @version > 0.4.0-prerelease
         class Bar; end
@@ -87,7 +87,7 @@ class Buzz; end
 
       tree = Parser.parse_string(rbi)
 
-      Rewriters::FilterVersions.filter(tree, Gem::Version.new("0.4.0"))
+      tree.filter_versions!(Gem::Version.new("0.4.0"))
       assert_equal(<<~RBI, tree.string)
         # @version = 0.4.0
         class Baz; end
@@ -111,7 +111,7 @@ class Buzz; end
 
       tree = Parser.parse_string(rbi)
 
-      Rewriters::FilterVersions.filter(tree, Gem::Version.new("0.4.0"))
+      tree.filter_versions!(Gem::Version.new("0.4.0"))
       assert_equal(<<~RBI, tree.string)
         # @version != 1.0.0
         class Foo; end
@@ -138,7 +138,7 @@ class Baz; end
 
       tree = Parser.parse_string(rbi)
 
-      Rewriters::FilterVersions.filter(tree, Gem::Version.new("1.1.5"))
+      tree.filter_versions!(Gem::Version.new("1.1.5"))
       assert_equal(<<~RBI, tree.string)
         # @version ~> 1.1.0
         class Foo; end
@@ -162,7 +162,7 @@ class Buzz; end
 
       tree = Parser.parse_string(rbi)
 
-      Rewriters::FilterVersions.filter(tree, Gem::Version.new("0.4.0"))
+      tree.filter_versions!(Gem::Version.new("0.4.0"))
       assert_equal(<<~RBI, tree.string)
         # @version >= 0.4.0-prerelease
         class Bar; end
@@ -192,7 +192,7 @@ class Buzz; end
 
       tree = Parser.parse_string(rbi)
 
-      Rewriters::FilterVersions.filter(tree, Gem::Version.new("0.4.0"))
+      tree.filter_versions!(Gem::Version.new("0.4.0"))
       assert_equal(<<~RBI, tree.string)
         # @version <= 1.0.0
         class Foo; end
@@ -219,7 +219,7 @@ class Buzz; end
 
       tree = Parser.parse_string(rbi)
 
-      Rewriters::FilterVersions.filter(tree, Gem::Version.new("0.4.0-prerelease"))
+      tree.filter_versions!(Gem::Version.new("0.4.0-prerelease"))
       assert_equal(<<~RBI, tree.string)
         # @version <= 1.0.0
         class Foo; end
@@ -246,7 +246,7 @@ class Baz; end
 
       tree = Parser.parse_string(rbi)
 
-      Rewriters::FilterVersions.filter(tree, Gem::Version.new("0.4.0"))
+      tree.filter_versions!(Gem::Version.new("0.4.0"))
       assert_equal(<<~RBI, tree.string)
         # @version > 0.3.0, < 1.0.0
         class Foo; end
@@ -274,7 +274,7 @@ class Baz; end
 
       tree = Parser.parse_string(rbi)
 
-      Rewriters::FilterVersions.filter(tree, Gem::Version.new("0.4.0"))
+      tree.filter_versions!(Gem::Version.new("0.4.0"))
       assert_equal(<<~RBI, tree.string)
         # @version = 0.4.0
         # @version > 0.5.0
@@ -299,7 +299,7 @@ class Baz; end
 
       tree = Parser.parse_string(rbi)
 
-      Rewriters::FilterVersions.filter(tree, Gem::Version.new("0.4.0"))
+      tree.filter_versions!(Gem::Version.new("0.4.0"))
       assert_equal(<<~RBI, tree.string)
         # @version > 0.3.0, < 1.0.0
         # @version > 1.5.0
@@ -320,7 +320,7 @@ class Foo; end
       tree = Parser.parse_string(rbi)
 
       assert_raises(Gem::Requirement::BadRequirementError) do
-        Rewriters::FilterVersions.filter(tree, Gem::Version.new("0.4.0"))
+        tree.filter_versions!(Gem::Version.new("0.4.0"))
       end
     end
   end