Change the FilterVersions rewriter tests to use the filter_versions! method
#269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
approved these changes
Feb 22, 2024
Morriar
reviewed
Feb 22, 2024
| @@ -15,7 +15,7 @@ class Buzz; end | |||
|
|
|||
| tree = Parser.parse_string(rbi) | |||
|
|
|||
| Rewriters::FilterVersions.filter(tree, Gem::Version.new("0.4.0")) | |||
There was a problem hiding this comment.
Let's keep one test using the class method version, as it's also part of the public API
There was a problem hiding this comment.
egiurleo
force-pushed
the
emily/filter-versions-test
branch
from
84561f9 to
55cdd73
Compare
Morriar
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Morriar pointed out that the
Tree#filter_versions!method looks like deadcode because it's not tested anywhere. I've changed theFilterVersionstests to call this method instead of using the underlying API, as I would expect a consumer to do.Note: this also matches the
SortNodestests