Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new open file argument format #410

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Use new open file argument format #410

merged 1 commit into from
Jul 16, 2024

Conversation

vinistock
Copy link
Member

Use the new open file format introduced in Shopify/ruby-lsp#2312. Standardizing on that format means we can provide code lens for jumping to views as well.

@vinistock vinistock self-assigned this Jul 15, 2024
@vinistock vinistock requested a review from a team as a code owner July 15, 2024 20:34
@vinistock vinistock requested review from andyw8 and st0012 July 15, 2024 20:34
Copy link
Contributor

@andyw8 andyw8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to ensure Shopify/ruby-lsp#2312 ships first.

@vinistock vinistock merged commit b31e9ff into main Jul 16, 2024
40 checks passed
@vinistock vinistock deleted the vs/use_new_open_format branch July 16, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants