Accept multiple URIs for the open file command #2312
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR starts accepting a list of URIs for the open file command. This will be necessary for allowing the jump to view feature to exist, since applications may define multiple views for the same controller action with different formats (e.g.: index.html.erb, index.json.jbuilder).
Implementation
The idea is to accept full URIs from the server. If there's only one, we open that directly. Otherwise, we show a quick pick and allow the user to choose.
Then we invoke
vscode.open
which already handles ranges in the URI fragment for us.