Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept multiple URIs for the open file command #2312

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

vinistock
Copy link
Member

Motivation

This PR starts accepting a list of URIs for the open file command. This will be necessary for allowing the jump to view feature to exist, since applications may define multiple views for the same controller action with different formats (e.g.: index.html.erb, index.json.jbuilder).

Implementation

The idea is to accept full URIs from the server. If there's only one, we open that directly. Otherwise, we show a quick pick and allow the user to choose.

Then we invoke vscode.open which already handles ranges in the URI fragment for us.

@vinistock vinistock added enhancement New feature or request vscode This pull request should be included in the VS Code extension's release notes labels Jul 15, 2024
@vinistock vinistock self-assigned this Jul 15, 2024
@vinistock vinistock requested a review from a team as a code owner July 15, 2024 20:31
@vinistock vinistock requested review from andyw8 and st0012 July 15, 2024 20:31
@vinistock vinistock merged commit c36e1d5 into main Jul 15, 2024
35 checks passed
@vinistock vinistock deleted the vs/accept_multiple_uris_for_open_file branch July 15, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request vscode This pull request should be included in the VS Code extension's release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants