Avoid a deprecation warning on Ruby 3.4 with the uri gem #2618
+17
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
reviewed
Sep 30, 2024
vinistock
added
server
I openend a PR to tapioca, which needs the same change: Shopify/tapioca#2026
Earlopain
force-pushed
the
uri-parser-changes
branch
from
21a51a7 to
b6d38cc
Compare
vinistock
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Calling
URI::DEFAULT_PARSER.escapeemits a deprecation warning with the uri gem shipped with Ruby 3.4:Implementation
Check for the precence of the new
RFC2396_PARSERconstant and use that if available. Otherwise fall back toDEFAULT_PARSER, which will be anRFC2396_Parserinstance in that case.Tapioca changes: Shopify/tapioca#2026
Automated Tests
n/A
Manual Tests
Run tests with ruby-head and warnings enabled:
RUBYOPT=-w VERBOSE=1 bundle exec rake