Avoid a deprecation warning on Ruby 3.4 with the uri gem #2026
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Avoid a deprecation warning on ruby 3.4 with the uri gem.
Implementation
uri
for Ruby 3.4 switched the default parser from RFC2396 to RFC3986. The new parser emits a deprecationwarning on a few methods and delegates them to RFC2396, namely
extract
/make_regexp
/escape
/unescape
.On earlier versions of the uri gem, the RFC2396_PARSER constant doesn't exist, so it needs some special
handling to select a parser that doesn't emit deprecations. While it was backported to Ruby 3.1, users may
have the uri gem in their own bundle and thus not use a compatible version.
Additional info:
Tests
Not needed. You can verify this yourself by doing the following:
gem "uri", github: "ruby/uri"
to the gemfileRUBYOPT="-w" bundle exec rake test TEST=spec/tapioca/gem/pipeline_spec.rb TESTOPTS="--name=/location/"