Skip to content

Conversation

@vinistock
Copy link
Member

Closes #3809

Unfortunately, we continue to receive reports of issues related to trying to reuse the Prism result for RuboCop. Let's revert this for now and make time to investigate in more detail.

@vinistock vinistock self-assigned this Nov 18, 2025
@vinistock vinistock added the bugfix This PR will fix an existing bug label Nov 18, 2025
@vinistock vinistock requested a review from a team as a code owner November 18, 2025 20:55
@vinistock vinistock added the server This pull request should be included in the server gem's release notes label Nov 18, 2025
@graphite-app
Copy link

graphite-app bot commented Nov 18, 2025

How to use the Graphite Merge Queue

Add the label graphite-merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Copy link

@adsteel adsteel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Today I commented out these lines and my issues went away.

@vinistock vinistock enabled auto-merge (squash) November 18, 2025 22:02
@vinistock vinistock merged commit 5be134e into main Nov 18, 2025
37 of 72 checks passed
@vinistock vinistock deleted the revert-3729-reuse-prism-result branch November 18, 2025 22:32
@connorshea
Copy link

connorshea commented Nov 20, 2025

FWIW if you need better reproduction steps when re-introducing this, I was able to consistently crash diagnostics the other day by doing a find-and-replace on 10+ files, which caused a violation of our linelength setting (e.g. replace string with stringthatismuchlonger), and thus had Cursor (and presumably VS Code) auto-format the lines that changed to be below the length limit.

It seemed to cause bizarre corruption of the file, with spaces and such randomly thrown in, and crashed diagnostics even after I fully restarted my editor to try it again.

@vinistock
Copy link
Member Author

Thank you @connorshea, that's really helpful. We had other reports of find and replace producing weird results too, so it seems like the most reliable way of reproducing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix This PR will fix an existing bug server This pull request should be included in the server gem's release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RuboCop crashes with the new ruby-lsp version 0.26.2

3 participants