Reuse the prism result again #3729
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
Earlopain
force-pushed
the
reuse-prism-result
branch
from
6c142d5 to
b49be8b
Compare
RuboCop 1.80.1 contains a fix for why this was broken, so it should be safe to enable this again. Revert: Shopify#3672 Fix: rubocop/rubocop#14478
Earlopain
force-pushed
the
reuse-prism-result
branch
from
b49be8b to
94bfccb
Compare
vinistock
added
enhancement
vinistock
approved these changes
Aug 28, 2025
Member
vinistock
left a comment
vinistock
left a comment
There was a problem hiding this comment.
Awesome! Really excited to see this land again
vinistock
added a commit
that referenced
this pull request
Nov 18, 2025
This reverts commit 8cbd8f8.
vinistock
added a commit
that referenced
this pull request
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
RuboCop 1.80.1 contains a fix for why this was broken and subsequently disabled, so it should be safe to enable this again.
Revert: #3672
Fix: rubocop/rubocop#14478
Implementation
Check the version and only reuse if it is known to be working.
Automated Tests
None, rubocop contains the tests
Manual Tests
Confirmed that on older versions the prism result is not being set. Also checked that the original errors doesn't happen anymore. As far as I can tell, that is the case. Specifically, the bug triggered (but not exclusivly so) when
defwas indented further than the correspondingendkeyword and formatting happened.