Constrain Zeitwerk to 2.6.5 #1059
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nelsonwittwer
approved these changes
Nov 15, 2022
nelsonwittwer
pushed a commit
that referenced
this pull request
Nov 15, 2022
Co-authored-by: Andy Waite <andyw8@users.noreply.github.com>
nelsonwittwer
added a commit
that referenced
this pull request
Nov 18, 2022
* make session storage optional * deprecate session storage * logging * cleaner deprecation strategy * Clarify statement about packages (#1057) Co-authored-by: Andy Waite <andyw8@users.noreply.github.com> * Constrain Zeitwerk to 2.6.5 (#1059) Co-authored-by: Andy Waite <andyw8@users.noreply.github.com> * Update lib/shopify_api/context.rb Co-authored-by: Andy Waite <13400+andyw8@users.noreply.github.com> * Update lib/shopify_api/utils/session_utils.rb Co-authored-by: Kevin O'Sullivan <56687600+mkevinosullivan@users.noreply.github.com> * clean up deprecation logging * raise error if trying to use deprecrated utils without session_storage * throw error if misconfigured session_storage * Update lib/shopify_api/context.rb Co-authored-by: Kevin O'Sullivan <56687600+mkevinosullivan@users.noreply.github.com> * change to more helpful upgrade instructions * rubocop line length * Update lib/shopify_api/context.rb Co-authored-by: Kevin O'Sullivan <56687600+mkevinosullivan@users.noreply.github.com> * Update lib/shopify_api/context.rb Co-authored-by: Kevin O'Sullivan <56687600+mkevinosullivan@users.noreply.github.com> * rubocop Co-authored-by: Andy Waite <13400+andyw8@users.noreply.github.com> Co-authored-by: Andy Waite <andyw8@users.noreply.github.com> Co-authored-by: Kevin O'Sullivan <56687600+mkevinosullivan@users.noreply.github.com>
kaarelss
added a commit
to kaarelss/shopify-api-ruby
that referenced
this pull request
Nov 29, 2022
…y-api-ruby into response_in_error_object * 'response_in_error_object' of github.com:kaarelss/shopify-api-ruby: Added assertion that response is present in MaxHttpRetriesExceededError Added sorbet assertion Removed extra empty line ShopifyAPI::Clients::HttpResponse as argument for ShopifyAPI::Errors::HttpResponseError because code can be obtained from response as well as headers for custom retry logic Remove mentions of private apps (Shopify#1062) Fix ActiveSupport inflector dependency (Shopify#1063) Move Session Storage to `shopify_app` (Shopify#1055) Remove session argument from REST examples (Shopify#1064) Constrain Zeitwerk to 2.6.5 (Shopify#1059) Clarify statement about packages (Shopify#1057)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to resolve #1058 but couldn't figure out what's causing it, so for now I think it's better to set this constraint.