Remove session argument from REST examples #1064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyw8
commented
Nov 16, 2022
| @@ -109,10 +109,10 @@ With this, a lot changed in how apps access the library. Here are the updates yo | |||
|
|
|||
| | Before | After | | |||
| | --- | --- | | |||
| | `Order.find(:all, params: {param1: value1})` | `Order.all(param1: value1, session:)` | | |||
| | `Order.find(<id>)` | `Order.find(id: <id>, session:)` | | |||
| | `order = Order.new(<id>)`<br/>`order.post(:close)` | `order = Order.new(session:)`<br/>`order.close()` | | |||
There was a problem hiding this comment.
I removed the () from close() since empty arguments are usually omitted in Ruby.
nelsonwittwer
approved these changes
Nov 16, 2022
kaarelss
added a commit
to kaarelss/shopify-api-ruby
that referenced
this pull request
Nov 29, 2022
…y-api-ruby into response_in_error_object * 'response_in_error_object' of github.com:kaarelss/shopify-api-ruby: Added assertion that response is present in MaxHttpRetriesExceededError Added sorbet assertion Removed extra empty line ShopifyAPI::Clients::HttpResponse as argument for ShopifyAPI::Errors::HttpResponseError because code can be obtained from response as well as headers for custom retry logic Remove mentions of private apps (Shopify#1062) Fix ActiveSupport inflector dependency (Shopify#1063) Move Session Storage to `shopify_app` (Shopify#1055) Remove session argument from REST examples (Shopify#1064) Constrain Zeitwerk to 2.6.5 (Shopify#1059) Clarify statement about packages (Shopify#1057)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In most cases
sessioncan use the default ofShopifyAPI::Context.active_session, so it's not necessary to pass it. This helps to simplify the examples.