Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit parallel work to PARALLEL_PROCESSOR_COUNT #1475

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

GoodForOneFare
Copy link
Member

Motivation

Fixes #1224 by syncing tapioca's parallelism behaviour with the Parallel gem's behaviour.

Implementation

Added a helper to mimic Parallel's behaviour. The tests are a little more involved than the rest of Tapioca's, so please let me know if those can be simplified 🙏

Tests

✅ There are tests!

@GoodForOneFare GoodForOneFare requested a review from a team as a code owner April 13, 2023 17:45
Copy link

@walsarraj walsarraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thank you!

Copy link

@ryoung2512 ryoung2512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this 🚀

@GoodForOneFare GoodForOneFare merged commit 244099d into main Apr 13, 2023
@GoodForOneFare GoodForOneFare deleted the limit-parallel-work branch April 13, 2023 18:14
@shopify-shipit shopify-shipit bot temporarily deployed to production May 12, 2023 12:20 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow PARALLEL_PROCESSOR_COUNT to override nprocessors when setting number_of_workers
3 participants