-
-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New installation script for UNIX #469
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reviewed.
Fix wrong author name Update version from 2.2 to 3.0 Remove unneeded code from initial config Change two git commands with wrong project name
More than the changes requested, I took the time to clean every other mistake I found. Now, it's good to go. 🎉 |
Hm.. I don't like the default behavior is overwritten. I think the overwrite is only if users want.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keep_config
behavior must be default.
bin/installer.sh
Outdated
while [ $# -gt 0 ]; do | ||
case $1 in | ||
--keep-config | -K) KEEP_CONFIG=yes ;; | ||
esac | ||
shift | ||
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take dein installation directory argument for the compatibility.
Others are OK. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take dein installation directory argument for the compatibility.
And please fix |
I could do that. But in another PR, to keep everything clean and organized. |
OK. LGTM. |
Merged. Thanks. |
Hi, Ned here.
In this script, all the logic I used was production-ready and in active use. I guess there shouldn't be any problem with this one.
However, I still ask if you have a working UNIX (eg. macOS or Linux Distros) test this out. Any feedback is appreciated.
Features
Examples
Test the new script by running one of the following commands:
In some case users might wan't to keep the current vim config, so to handle that I added the
--keep-config | -K
arguments, which can be passed to the installation script, like this:When needed this will allow the script to verify if the vim or nvim config exist, if true it'll generate the
.vimrc
config at the dein.vim base path, if false it'll overwrite any config if existent.Issues
Closes #467