Feature/105 add tray icon #101
Conversation
app/setup-tray-icon.js
Outdated
| let appIcon = null | ||
| const iconPath = path.join(__dirname, '../docs/logo.png') | ||
|
|
||
| function setupTrayIcon () { |
There was a problem hiding this comment.
Disable here the trayicon on macOS! There is no need for that as the app on that platform will not quit if all the windows are closed.
app/setup-tray-icon.js
Outdated
|
|
||
| let appIcon = null | ||
| const iconPath = path.join(__dirname, '../docs/logo.png') | ||
|
|
|
If I close the main window i can't see the trayicon on Ubuntu 16.04
on macOS (which should be disabled) I see a giant icon :D
|
app/setup-tray-icon.js
Outdated
| import { app, Menu, Tray } from 'electron' | ||
|
|
||
| let appIcon = null | ||
| const iconPath = path.join(__dirname, '../docs/logo.png') |
There was a problem hiding this comment.
Use NativeImage (https://electronjs.org/docs/api/native-image#nativeimagecreatefrompathpath)
This will ensure to have the best graphics and scaled image. AFAIK
|
Let me know if the latest commit solves this :) |
|
It looks like it (I will test it this evening) The Ubuntu one seems to be a Distro/Configuration-driven situation. |
|
By installing it from the dpkg and then running it it works :) |
|
dpkg dependencies added to the docs so we know that when running from source the user should install the appindicator/missing pkgs! Ready to merge |
What changed?
Added tray icon.
Now the app runs in the background when you close all windows, unless you quit from the tray icon.