This repository has been archived by the owner on Jul 7, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 16
Feature/105 add tray icon #101
Merged
Merged
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
87a6565
Add tray icon
kernelwhisperer bff74a9
Add check for ipfs exiting with null
kernelwhisperer 20a4d09
Skip setting up tray for macOS, add docs, use nativeimage
kernelwhisperer 2990f79
Merge branch 'master' into feature/105-add-tray-icon
koalalorenzo fc04df7
Merge branch 'master' into feature/105-add-tray-icon
koalalorenzo 0882711
adds dependencies from dpkg
koalalorenzo 8f23160
Merge branch 'master' into feature/105-add-tray-icon
kernelwhisperer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
import path from 'path' | ||
import { app, Menu, Tray } from 'electron' | ||
|
||
let appIcon = null | ||
const iconPath = path.join(__dirname, '../docs/logo.png') | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Docs? Maybe? :D |
||
function setupTrayIcon () { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Disable here the trayicon on macOS! There is no need for that as the app on that platform will not quit if all the windows are closed. |
||
appIcon = new Tray(iconPath) | ||
const contextMenu = Menu.buildFromTemplate([ | ||
{ | ||
label: 'Open Siderus Orion', | ||
click () { | ||
app.emit('activate') | ||
} | ||
}, | ||
{ | ||
label: 'Quit', | ||
click () { | ||
app.quit() | ||
} | ||
} | ||
]) | ||
|
||
// Call this again for Linux because we modified the context menu | ||
appIcon.setContextMenu(contextMenu) | ||
} | ||
|
||
export default setupTrayIcon |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use NativeImage (https://electronjs.org/docs/api/native-image#nativeimagecreatefrompathpath)
This will ensure to have the best graphics and scaled image. AFAIK