This repository has been archived by the owner on Jul 7, 2024. It is now read-only.
Add "About Orion" window #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koalalorenzo
suggested changes
Aug 11, 2018
app/menu.js
Outdated
| } else { | ||
| // process.platform !== 'darwin' | ||
| // on windows and linux only | ||
| const aboutOrion = { |
There was a problem hiding this comment.
Should we use this also on macOS?
koalalorenzo
suggested changes
Aug 11, 2018
app/menu.js
Outdated
| @@ -146,6 +146,11 @@ const template = [{ | |||
| label: 'Help', | |||
| role: 'help', | |||
| submenu: [{ | |||
| label: 'About Orion', | |||
There was a problem hiding this comment.
I guess macOS Users are expecting the About to be under the "Orion" Menu (as it was).
Can we add About Orion here just for Win+Gnu and under the Mac-only menu for Mac?
koalalorenzo
approved these changes
Aug 13, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added the About window on linux and win32. Should we add this to mac as well?