Skip to content
This repository has been archived by the owner on Jul 7, 2024. It is now read-only.
/ Orion Public archive

Add "About Orion" window #172

Merged
merged 4 commits into from
Aug 13, 2018
Merged

Add "About Orion" window #172

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b2eb4da
Add About Orion window
kernelwhisperer Aug 11, 2018
80f1c7b
Fix AboutWindow size
kernelwhisperer Aug 11, 2018
7c59d34
Add AboutWindow to macOS
kernelwhisperer Aug 11, 2018
b8583ae
Fix About Orion menu location for mac
kernelwhisperer Aug 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 5 additions & 16 deletions app/menu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,11 @@ const template = [{
label: 'Help',
role: 'help',
submenu: [{
label: 'About Orion',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess macOS Users are expecting the About to be under the "Orion" Menu (as it was).

Can we add About Orion here just for Win+Gnu and under the Mac-only menu for Mac?

click () {
AboutWindow.create(app)
}
}, {
label: 'Suggest new feature',
click () {
electron.shell.openExternal('https://github.com/Siderus/Orion/issues/new?template=Feature_request.md')
Expand Down Expand Up @@ -212,11 +217,6 @@ if (process.platform === 'darwin') {
template.unshift({
label: name,
submenu: [{
label: `About ${name}`,
role: 'about'
}, {
type: 'separator'
}, {
label: 'Services',
role: 'services',
submenu: []
Expand Down Expand Up @@ -261,17 +261,6 @@ if (process.platform === 'darwin') {
})

addUpdateMenuItems(template[0].submenu, 1)
} else {
// process.platform !== 'darwin'
// on windows and linux only
const aboutOrion = {
label: 'About Orion',
click () {
AboutWindow.create(app)
}
}

template[4].submenu.unshift(aboutOrion)
}

if (process.platform === 'win32') {
Expand Down