Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added support for bar chart stacking #5138

Merged
merged 22 commits into from
Jun 10, 2024
Merged

feat: added support for bar chart stacking #5138

merged 22 commits into from
Jun 10, 2024

Conversation

vikrantgupta25
Copy link
Member

@vikrantgupta25 vikrantgupta25 commented Jun 3, 2024 •
edited
Loading

Summary

  • added stacking options for bar charts

Related Issues / PR's

fixes #4959

Screenshots

Screen.Recording.2024-06-06.at.2.31.43.AM.mov

Affected Areas and Manually Tested Areas

@github-actions github-actions bot added the enhancement New feature or request label Jun 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 5, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@vikrantgupta25 vikrantgupta25 changed the title feat: stacked bars uplot poc feat: added support for bar chart stacking Jun 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 5, 2024

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@vikrantgupta25 vikrantgupta25 marked this pull request as ready for review June 5, 2024 21:00
@vikrantgupta25 vikrantgupta25 requested a review from YounixM as a code owner June 5, 2024 21:00
@vikrantgupta25 vikrantgupta25 force-pushed the uplot-stacked-bar-poc branch from 0b9054b to fbca1a9 Compare June 5, 2024 21:00
SagarRajput-7
SagarRajput-7 previously approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@SagarRajput-7 SagarRajput-7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YounixM
Copy link
Member

YounixM commented Jun 10, 2024

Screenshot 2024-06-10 at 2 00 35 PM

The highest bar doesnt have filled color when other bars are deselected.

@YounixM
Copy link
Member

YounixM commented Jun 10, 2024

Dashboard Edit View (generic issue) - There is shift in width when we add a 2nd query

@vikrantgupta25
Copy link
Member Author

vikrantgupta25 commented Jun 10, 2024 •
edited
Loading

Dashboard Edit View (generic issue) - There is shift in width when we add a 2nd query

will pick this up separately 👍 #5180 added here itself

@vikrantgupta25
Copy link
Member Author

vikrantgupta25 commented Jun 10, 2024 •
edited
Loading

Screenshot 2024-06-10 at 2 00 35 PM

The highest bar doesnt have filled color when other bars are deselected.

  • fixed the issue, we will not have the graph manager in the bar charts, the uplot hide and show for bar charts stacked is not built on multiple series. we show and hide only one legend at a time

@vikrantgupta25
Copy link
Member Author

image

added the info text

@vikrantgupta25
Copy link
Member Author

Dashboard Edit View (generic issue) - There is shift in width when we add a 2nd query

Fixed here - #5182

@vikrantgupta25 vikrantgupta25 merged commit f2aba50 into develop Jun 10, 2024
11 of 12 checks passed
@vikrantgupta25 vikrantgupta25 deleted the uplot-stacked-bar-poc branch June 10, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YounixM YounixM YounixM approved these changes

@SagarRajput-7 SagarRajput-7 SagarRajput-7 left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stacked bars in bar chart
3 participants
@vikrantgupta25 @YounixM @SagarRajput-7