Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unsaved changes popping up for newly created dashboard in settings #5182

Merged
merged 3 commits into from
Jun 10, 2024

Conversation

vikrantgupta25
Copy link
Member

@vikrantgupta25 vikrantgupta25 commented Jun 10, 2024

Summary

  • unsaved changes popping up in the side drawer for new dashboards ( the comparisons didn't take in account for default values )
  • updated the text from change to changes in case of more than 1 change
  • fixed the changing width of right and left container

Related Issues / PR's

fixes #5180

Screenshots

Screen.Recording.2024-06-10.at.4.44.10.PM.mov
Screen.Recording.2024-06-10.at.5.02.24.PM.mov

Affected Areas and Manually Tested Areas

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the bug Something isn't working label Jun 10, 2024
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@vikrantgupta25 vikrantgupta25 marked this pull request as ready for review June 10, 2024 11:33
@vikrantgupta25 vikrantgupta25 requested a review from YounixM as a code owner June 10, 2024 11:33
@vikrantgupta25 vikrantgupta25 force-pushed the dashboard-unsaved-changes branch from 1dabf8a to 687be51 Compare June 10, 2024 12:07
@vikrantgupta25 vikrantgupta25 merged commit a3e36cb into develop Jun 10, 2024
12 checks passed
@vikrantgupta25 vikrantgupta25 deleted the dashboard-unsaved-changes branch June 10, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboards - Configure your dashboard shows 3 unsaved changes without any changes
2 participants