-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable offline functionality for frontend #6152
Conversation
Welcome to the SigNoz community! Thank you for your first pull request and making this project better. 🤗 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Reviewed everything up to 2a1e8da in 27 seconds
More details
- Looked at
90
lines of code in3
files - Skipped
5
files when reviewing. - Skipped posting
2
drafted comments based on config settings.
1. frontend/src/index.html.ejs:55
- Draft comment:
The external font links have been removed, but the HTML does not reference the locally defined fonts. Ensure that the HTML or CSS uses the locally defined fonts fromstyles.scss
. - Reason this comment was not posted:
Comment did not seem useful.
2. frontend/src/styles.scss:277
- Draft comment:
Avoid hardcoding color values likergb(136, 136, 136)
. Use design tokens or predefined color constants instead. This applies to other color values in this file as well. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_9obqgpOwqsvQ2Ek3
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
the changes look good, can you attach a video recording with launching query service locally / frontend locally and turn off the internet access. Load certain dashboards and check if things are looking fine ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@saichander17 Can you please sign the CLA? https://cla-assistant.io/SigNoz/signoz?pullRequest=6152 |
Summary
This PR removes functionality which downloads fonts/css files from internet and puts them available in the local build itself. The UI seems to call other domains as well but they don't block the UI until timeout occurs and hence it's not causing any functionality issues.
Problems this PR solves in airgapped environments
Related Issues / PR's
Fix for: #5036
External domains still being called from the frontend
These domains still get called from the UI but they don't block the UI until timeout or anything as per my testing.
Known problems
Clarifications needed
My suggestion would be to go ahead and merge the PR as it at least solves the biggest issues in airgapped environments right now and take other updates periodically.
Important
Enable offline functionality by localizing fonts and CSS in the frontend, addressing airgapped environment issues.
index.html.ejs
, replacing them with local paths.uPlot.min.css
topublic/css
and updatesindex.html.ejs
to use it locally.@font-face
declarations instyles.scss
forInter
,Work Sans
,Space Mono
, andFira Code
fonts, sourcing them from local files.index.html.ejs
to use local images instead of external URLs.This description was created by
for 2a1e8da. It will automatically update as commits are pushed.