-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: added handling for new key - duration_nano in traces #6658
base: main
Are you sure you want to change the base?
Conversation
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to b6159a7 in 12 seconds
More details
- Looked at
40
lines of code in3
files - Skipped
0
files when reviewing. - Skipped posting
2
drafted comments based on config settings.
1. frontend/src/container/TimeSeriesView/index.tsx:32
- Draft comment:
Consider defining a constant for 'durationNano' and 'duration_nano' to avoid repetition and potential errors in future changes. This applies to similar checks in other files as well. - Reason this comment was not posted:
Confidence changes required:50%
The code changes are consistent across files, ensuring both 'durationNano' and 'duration_nano' are handled. However, the code could be improved for maintainability by using a constant for these keys.
2. frontend/src/container/TracesExplorer/ListView/utils.tsx:102
- Draft comment:
Avoid using inline styles. Consider using CSS classes or styled components instead. This is also applicable in other parts of the code where inline styles are used. - Reason this comment was not posted:
Comment was not on a valid diff hunk.
Workflow ID: wflow_hZzwP0HPyFePJ6Og
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
b6159a7
to
cca1f0f
Compare
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
1 similar comment
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Summary
We have added
duration_nano
in as a suggestion when adding columns in traces table, but thems
conversion handling was missing. Added that.Related Issues / PR's
https://github.com/SigNoz/engineering-pod/issues/2095
Screenshots
Before:
After:
Affected Areas and Manually Tested Areas
Important
Add handling for
duration_nano
key alongsidedurationNano
in various components and utilities.duration_nano
key in addition todurationNano
inTimeSeriesViewContainer
inindex.tsx
.getSpanOrderParam
inutil.ts
to handleduration_nano
.getListColumns
inutils.tsx
to supportduration_nano
key for rendering duration in milliseconds.This description was created by for b6159a7. It will automatically update as commits are pushed.