Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added handling for new key - duration_nano in traces #6658

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+4 −3
Open

fix: added handling for new key - duration_nano in traces #6658

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cca1f0f
fix: added handling for new key - duration_nano in traces
SagarRajput-7 Dec 18, 2024
dbb27b1
Merge branch 'main' into SIG-2095
SagarRajput-7 Dec 23, 2024
bd18942
Merge branch 'main' into SIG-2095
srikanthccv Dec 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion frontend/src/container/TimeSeriesView/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@ function TimeSeriesViewContainer({
currentQuery.builder.queryData.forEach(
({ aggregateAttribute, aggregateOperator }) => {
const isExistDurationNanoAttribute =
aggregateAttribute.key === 'durationNano';
aggregateAttribute.key === 'durationNano' ||
aggregateAttribute.key === 'duration_nano';

const isCountOperator =
aggregateOperator === 'count' || aggregateOperator === 'count_distinct';
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/container/Trace/TraceTable/util.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
export const getSpanOrderParam = (key: string): string => {
if (key === 'durationNano') {
if (key === 'durationNano' || key === 'duration_nano') {
return 'duration';
}
if (key === 'timestamp') {
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/container/TracesExplorer/ListView/utils.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ export const getListColumns = (
);
}

if (key === 'durationNano') {
if (key === 'durationNano' || key === 'duration_nano') {
return (
<BlockLink to={getTraceLink(item)} openInNewTab={false}>
<Typography data-testid={key}>{getMs(value)}ms</Typography>
Expand Down
Loading