Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add custom sort for EventController #305

Merged
merged 3 commits into from
Feb 22, 2024

Conversation

dumazy
Copy link
Contributor

@dumazy dumazy commented Jan 15, 2024

Description

Allows for adding a custom sort function. The fallback will be the default startTimeWise sorting. This will be used if no sorter was added or if the sorter returns 0.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

lib/src/extensions.dart Outdated Show resolved Hide resolved
Copy link
Collaborator

@ParthBaraiya ParthBaraiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ParthBaraiya ParthBaraiya merged commit 90818ea into SimformSolutionsPvtLtd:master Feb 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants