Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SyncOMatic.Sync() able to automatically open (and optionally merge) pull requests #2

Merged
merged 4 commits into from
Feb 25, 2014

Conversation

nulltoken
Copy link
Collaborator

Once octokit/octokit.net#360 is merged.

  • Add SyncOutput.CreatePullRequest
  • For each updated repo, create a new pull request targeting the newly created branch
  • Maybe add SyncOutput.CreateAndMergePullRequest (Leveraging the Status API (Commit Status API octokit/octokit.net#104) to determine if it's safe to auto-merge)

This leverages the local on-disk blob store and the various caches.
By minimizing the number of requests to the GH api, this makes the test run about 20% faster.
As this test mutates the state of the remote repositories, let's make sure it's not run by default.
@nulltoken
Copy link
Collaborator Author

Maybe add SyncOutput.CreateAndMergePullRequest (Leveraging the Status API (octokit/octokit.net#104) to determine if it's safe to auto-merge)

After having thought a bit about this, I'm not sure it's wise at this moment to automate to merging of the pull request. I'd vote to postpone this.

@andreasohlund
Copy link
Contributor

Lets move the open checkbox to a separate issue?

@nulltoken
Copy link
Collaborator Author

Lets move the open checkbox to a separate issue?

Done! see #5

andreasohlund added a commit that referenced this pull request Feb 25, 2014
Make SyncOMatic.Sync() able to automatically open (and optionally merge) pull requests
@andreasohlund andreasohlund merged commit 6d2528e into master Feb 25, 2014
@andreasohlund andreasohlund deleted the ntk/pull_request_creation branch February 25, 2014 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants