Implement Pull Requests API #360
Conversation
Still missing pull request files, commit lists and merge checks.
Still missing integration tests for Pull Requests, though. I need to do a bit more research before I can start to tackle that one.
Manually referenced as this requires Xamarin studio to do automatically.
Removed default parameter from pull request merge message according to CA1026.
Bugfix for building the merge api url, as well.
Renamed and enhanced existing Merged tests.
- Initial integration test for pull requests (can't seem to do much without the tree api) - Added Observable unit tests for the rest of the pull request client
NewPullRequest constructor only takes required params. Each required parameter is now a readonly property.
|
No problem, man. Sorry I never ended up finishing it... We've been in crunch mode at the office for a while now and I really haven't had any time to give octokit any love :( Thanks for all the help! |
|
dropped the [WIP] tag Ready to review |
| return _connection.GetAndFlattenAllPages<Commit>(ApiUrls.PullRequestCommits(owner, name, number)); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Hey! I'm saving them for a rainy day! 
|
👍💣💥🔥 Strangely qed build 673 doesn't appear in the recent builds lists. Caching issue? /cc @half-ogre |
|
|
||
| namespace Octokit | ||
| { | ||
| public class PullRequestCommit |
There was a problem hiding this comment.
Documentation? It's fine to do it later. :)
|
|
|
BTW, there's an alternate way to create a pull request using an issue number: http://developer.github.com/v3/pulls/#create-a-pull-request It looks like this PR doesn't support that. Perhaps we can log another issue for that just to track it. |
|
Lo and behold! Once again, you are way ahead of me Mr. @shiftkey. |
Hey @jpsullivan I'm going to finish this off as it's something I want to start using (and also the oldest PR).
Supersedes #173
Implements http://developer.github.com/v3/pulls/