Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Pull Requests API #360

Merged
merged 44 commits into from
Feb 19, 2014
Merged

Implement Pull Requests API #360

merged 44 commits into from
Feb 19, 2014

Commits on Feb 3, 2014

  1. Stubbed out the API for pull requests. 

    Still missing pull request files, commit lists and merge checks.
    @jpsullivan @shiftkey
    jpsullivan authored and shiftkey committed Feb 3, 2014
    Configuration menu
    Copy the full SHA
    e3bf6ed View commit details
    Browse the repository at this point in the history

  2. Stubbed out the reactive Pull Request functionality

    @jpsullivan @shiftkey
    jpsullivan authored and shiftkey committed Feb 3, 2014
    Configuration menu
    Copy the full SHA
    dd220d7 View commit details
    Browse the repository at this point in the history

  3. Tested out all of the existing Pull Request code 

    Still missing integration tests for Pull Requests, though.  I need to do
a bit more research before I can start to tackle that one.
    @jpsullivan @shiftkey
    jpsullivan authored and shiftkey committed Feb 3, 2014
    Configuration menu
    Copy the full SHA
    c81d8d0 View commit details
    Browse the repository at this point in the history

  4. Fixed some goofed up test names

    @jpsullivan @shiftkey
    jpsullivan authored and shiftkey committed Feb 3, 2014
    Configuration menu
    Copy the full SHA
    6323b62 View commit details
    Browse the repository at this point in the history

  5. Documented missing properties; Whitespace and typo tomfoolery patched

    @jpsullivan @shiftkey
    jpsullivan authored and shiftkey committed Feb 3, 2014
    Configuration menu
    Copy the full SHA
    a67ce05 View commit details
    Browse the repository at this point in the history

  6. Referenced pull request functionality for Mono projects 

    Manually referenced as this requires Xamarin studio to do automatically.
    @jpsullivan @shiftkey
    jpsullivan authored and shiftkey committed Feb 3, 2014
    Configuration menu
    Copy the full SHA
    a2d3036 View commit details
    Browse the repository at this point in the history

  7. Implemented pull request merge functionality

    @jpsullivan @shiftkey
    jpsullivan authored and shiftkey committed Feb 3, 2014
    Configuration menu
    Copy the full SHA
    fddae25 View commit details
    Browse the repository at this point in the history

  8. Merge comments default to an empty string as they are optional.

    @jpsullivan @shiftkey
    jpsullivan authored and shiftkey committed Feb 3, 2014
    Configuration menu
    Copy the full SHA
    6c7f756 View commit details
    Browse the repository at this point in the history

  9. Patched up some issues from the upstream merge. 

    Removed default parameter from pull request merge message according to
CA1026.
    @jpsullivan @shiftkey
    jpsullivan authored and shiftkey committed Feb 3, 2014
    Configuration menu
    Copy the full SHA
    c1e6d1e View commit details
    Browse the repository at this point in the history

  10. Added tests for the Merge method

    @jpsullivan @shiftkey
    jpsullivan authored and shiftkey committed Feb 3, 2014
    Configuration menu
    Copy the full SHA
    a2f3de4 View commit details
    Browse the repository at this point in the history

  11. Implemented Merged? functionality / tests 

    Bugfix for building the merge api url, as well.
    @jpsullivan @shiftkey
    jpsullivan authored and shiftkey committed Feb 3, 2014
    Configuration menu
    Copy the full SHA
    9d3f758 View commit details
    Browse the repository at this point in the history

  12. Unit test fixes

    @jpsullivan @shiftkey
    jpsullivan authored and shiftkey committed Feb 3, 2014
    Configuration menu
    Copy the full SHA
    c59c8c1 View commit details
    Browse the repository at this point in the history

  13. Pull request commit list now implemented / tested 

    Renamed and enhanced existing Merged tests.
    @jpsullivan @shiftkey
    jpsullivan authored and shiftkey committed Feb 3, 2014
    Configuration menu
    Copy the full SHA
    0db0307 View commit details
    Browse the repository at this point in the history

  14. PullRequest model now contains all of necessary fields 

    - Initial integration test for pull requests (can't seem to do much
without the tree api)
- Added Observable unit tests for the rest of the pull request client
    @jpsullivan @shiftkey
    jpsullivan authored and shiftkey committed Feb 3, 2014
    Configuration menu
    Copy the full SHA
    6546223 View commit details
    Browse the repository at this point in the history

  15. Merged now returns bool based on the request http response

    @jpsullivan @shiftkey
    jpsullivan authored and shiftkey committed Feb 3, 2014
    Configuration menu
    Copy the full SHA
    14236cd View commit details
    Browse the repository at this point in the history

  16. NewPullRequest required parameters altered 

    NewPullRequest constructor only takes required params.  Each required
parameter is now a readonly property.
    @jpsullivan @shiftkey
    jpsullivan authored and shiftkey committed Feb 3, 2014
    Configuration menu
    Copy the full SHA
    ad216b5 View commit details
    Browse the repository at this point in the history

  17. Fixed auto properties and moved integration tests around

    @jpsullivan @shiftkey
    jpsullivan authored and shiftkey committed Feb 3, 2014
    Configuration menu
    Copy the full SHA
    fc76ce0 View commit details
    Browse the repository at this point in the history

  18. Killed with the hottest fire.

    @jpsullivan @shiftkey
    jpsullivan authored and shiftkey committed Feb 3, 2014
    Configuration menu
    Copy the full SHA
    07faec8 View commit details
    Browse the repository at this point in the history

  19. fixing all the merge conflicts

    @shiftkey
    shiftkey committed Feb 3, 2014
    Configuration menu
    Copy the full SHA
    34df444 View commit details
    Browse the repository at this point in the history

  20. the unit tests now pass

    @shiftkey
    shiftkey committed Feb 3, 2014
    Configuration menu
    Copy the full SHA
    cb1a413 View commit details
    Browse the repository at this point in the history

  21. address some documentation feedback

    @shiftkey
    shiftkey committed Feb 3, 2014
    Configuration menu
    Copy the full SHA
    3f306fb View commit details
    Browse the repository at this point in the history

  22. finish up the <return> results, singular <summary>

    @shiftkey
    shiftkey committed Feb 3, 2014
    Configuration menu
    Copy the full SHA
    9dc4de5 View commit details
    Browse the repository at this point in the history

  23. ok, now the tests should pass

    @shiftkey
    shiftkey committed Feb 3, 2014
    Configuration menu
    Copy the full SHA
    a3190aa View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2014

  1. aren't value types great?

    @shiftkey
    shiftkey committed Feb 18, 2014
    Configuration menu
    Copy the full SHA
    e112125 View commit details
    Browse the repository at this point in the history

  2. added a test to create a pull request using the API

    @shiftkey
    shiftkey committed Feb 18, 2014
    Configuration menu
    Copy the full SHA
    af613a4 View commit details
    Browse the repository at this point in the history

  3. 💄

    @shiftkey
    shiftkey committed Feb 18, 2014
    Configuration menu
    Copy the full SHA
    e93a24e View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into shiftkey/revive-pull-requests

    @shiftkey
    shiftkey committed Feb 18, 2014
    Configuration menu
    Copy the full SHA
    dfc36a9 View commit details
    Browse the repository at this point in the history

  5. refactoring for reuse in test suite

    @shiftkey
    shiftkey committed Feb 18, 2014
    Configuration menu
    Copy the full SHA
    af9e8a2 View commit details
    Browse the repository at this point in the history

  6. added test for update and ensure history is respected when creating PRs

    @shiftkey
    shiftkey committed Feb 18, 2014
    Configuration menu
    Copy the full SHA
    af7196d View commit details
    Browse the repository at this point in the history

  7. added the delete test

    @shiftkey
    shiftkey committed Feb 18, 2014
    Configuration menu
    Copy the full SHA
    41e512d View commit details
    Browse the repository at this point in the history

  8. die duplication, die

    @shiftkey
    shiftkey committed Feb 18, 2014
    1 Configuration menu
    Copy the full SHA
    a1f5c49 View commit details
    Browse the repository at this point in the history

  9. can merge things wooooooooo

    @shiftkey
    shiftkey committed Feb 18, 2014
    Configuration menu
    Copy the full SHA
    da10d44 View commit details
    Browse the repository at this point in the history

  10. test that master reflects our merge commit found

    @shiftkey
    shiftkey committed Feb 18, 2014
    Configuration menu
    Copy the full SHA
    1a36dfa View commit details
    Browse the repository at this point in the history

  11. added tests for edge case scenarios

    @shiftkey
    shiftkey committed Feb 18, 2014
    Configuration menu
    Copy the full SHA
    d43bf50 View commit details
    Browse the repository at this point in the history

  12. 💄

    @shiftkey
    shiftkey committed Feb 18, 2014
    Configuration menu
    Copy the full SHA
    a23a8d3 View commit details
    Browse the repository at this point in the history

  13. updated docs

    @shiftkey
    shiftkey committed Feb 18, 2014
    Configuration menu
    Copy the full SHA
    93b8b27 View commit details
    Browse the repository at this point in the history

  14. one last test for browsing commits

    @shiftkey
    shiftkey committed Feb 18, 2014
    Configuration menu
    Copy the full SHA
    176f2ce View commit details
    Browse the repository at this point in the history

  15. whoops, let's tidy up

    @shiftkey
    shiftkey committed Feb 18, 2014
    Configuration menu
    Copy the full SHA
    33e908b View commit details
    Browse the repository at this point in the history

  16. 💄 grouping methods

    @shiftkey
    shiftkey committed Feb 18, 2014
    Configuration menu
    Copy the full SHA
    02f80a0 View commit details
    Browse the repository at this point in the history

  17. 💄 tidy up test code

    @shiftkey
    shiftkey committed Feb 18, 2014
    1 Configuration menu
    Copy the full SHA
    7684613 View commit details
    Browse the repository at this point in the history

  18. bugfix for PR commits having different shape to regular commits

    @shiftkey
    shiftkey committed Feb 18, 2014
    1 Configuration menu
    Copy the full SHA
    1231b79 View commit details
    Browse the repository at this point in the history

  19. 💄 whitespace

    @shiftkey
    shiftkey committed Feb 18, 2014
    Configuration menu
    Copy the full SHA
    7aed331 View commit details
    Browse the repository at this point in the history

  20. corrected impacted tests

    @shiftkey
    shiftkey committed Feb 18, 2014
    1 Configuration menu
    Copy the full SHA
    43be799 View commit details
    Browse the repository at this point in the history

  21. one last newline

    @shiftkey
    shiftkey committed Feb 18, 2014
    Configuration menu
    Copy the full SHA
    514c20e View commit details
    Browse the repository at this point in the history