Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engine update caused issue with opening multiple bags #1242

Closed
bruhmogus opened this issue Nov 18, 2024 · 1 comment
Closed

Engine update caused issue with opening multiple bags #1242

bruhmogus opened this issue Nov 18, 2024 · 1 comment
Labels
Type: Bug [Un]intentional issue with something

Comments

@bruhmogus
Copy link

Description

Opening a bag while in another bag causes the bag menu to disappear and the bag to remain "open"

Reproduction

  1. Open bag 1
  2. Open bag 2
  3. See your inventory disappear
  4. Press "Close bag"

Expected behavior

  1. Open bag 1
  2. Open bag 2
  3. See bag 2 inventory

Media

again, no OBS

Additional context

what did engine update even DO other than introduce like eight bugs that arent even ee

@bruhmogus bruhmogus added the Type: Bug [Un]intentional issue with something label Nov 18, 2024
@sleepyyapril
Copy link
Contributor

Additional context

what did engine update even DO other than introduce like eight bugs that arent even ee

it's to be expected with updating. bugs are fixable

VMSolidus pushed a commit that referenced this issue Nov 22, 2024
<!--
This is a semi-strict format, you can add/remove sections as needed but
the order/format should be kept the same
Remove these comments before submitting
-->

# Description

<!--
Explain this PR in as much detail as applicable

Some example prompts to consider:
How might this affect the game? The codebase?
What might be some alternatives to this?
How/Who does this benefit/hurt [the game/codebase]?
-->

Mass bug fixing, for bugs related to #1220.
Feel free to link or send bugs.

Fix list:
- #1242 
- #1243 
- #1244
- space-wizards/space-station-14#28084
- space-wizards/space-station-14#28282
- Actually fixed PirateRadioSpawnRule heisentest (with a bandaid) (I
cancel if it's 0)
- #1263

---

# Changelog

<!--
You can add an author after the `:cl:` to change the name that appears
in the changelog (ex: `:cl: Death`)
Leaving it blank will default to your GitHub display name
This includes all available types for the changelog
-->

:cl:
- fix: Fixed chair visuals drawing depth wrongly if you sat in a
north-facing chair.
- fix: Fixed buckling doing several buckles each time you did one.
- fix: Fixed the magic mirror.
- fix: Fixed beds re-positioning you every few seconds.
- fix: Fixed E not opening containers that are in another container.
- fix: Fixed disposal systems not flushing or ejecting properly.

---------

Co-authored-by: sleepyyapril <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>
Co-authored-by: Nemanja <98561806+EmoGarbage404@users.noreply.github.com>
VMSolidus added a commit that referenced this issue Jan 25, 2025
# Description

Ports MODsuits from Goobstation PR
Goob-Station/Goob-Station#1242. The PR author
has confirmed that he is okay with me doing this.

---

# TODO

- [X] Port in sprites
- [x] Port in YMLs
- [X] Port code
- [x] Port code PATCHES
- [x] Update EE with required fixes

---

<details><summary><h1>Media</h1></summary>
<p>

## Modsuit crafting


https://github.com/user-attachments/assets/8ff03d3a-0fc1-4818-b710-bfc43f0e2a68

## Modsuit sealing


https://github.com/user-attachments/assets/6671459a-7767-499b-8678-062fc1db7134

</p>
</details>

---

# Changelog

:cl:
- add: Modsuits have been ported from Goobstation!

---------

Signed-off-by: Eris <erisfiregamer1@gmail.com>
Co-authored-by: DEATHB4DEFEAT <77995199+DEATHB4DEFEAT@users.noreply.github.com>
Co-authored-by: VMSolidus <evilexecutive@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug [Un]intentional issue with something
Projects
None yet
Development

No branches or pull requests

3 participants