Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NotSerializableException for CraftMetaItem #3185

Closed
TPGamesNL opened this issue Jul 21, 2020 · 11 comments
Closed

NotSerializableException for CraftMetaItem #3185

TPGamesNL opened this issue Jul 21, 2020 · 11 comments
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. priority: high Issues with potentially high impact that could be harmful to users.

Comments

@TPGamesNL
Copy link
Member

TPGamesNL commented Jul 21, 2020

Description

A NotSerializableException is thrown whenever an item is saved to a global variable.

Steps to Reproduce

command /err:
	trigger:
		set {stone} to stone

Expected Behavior

No errors obviously

Errors / Screenshots

https://pastebin.com/P4W9BmaK

Server Information

  • Server version/platform: 1.15.2 (paper-379)
  • Skript version: 2.5-alpha6

Additional Context

None

@Pikachu920
Copy link
Member

@APickledWalrus

@APickledWalrus
Copy link
Member

Hey, does this occur every time you run the command? If so, does it occur with items that have names, enchantments, or etc.?

@APickledWalrus APickledWalrus added needs testing Needs testing to determine current status or issue validity, or for WIP feature pulls. priority: high Issues with potentially high impact that could be harmful to users. labels Jul 21, 2020
@TPGamesNL
Copy link
Member Author

TPGamesNL commented Jul 21, 2020

Yes, everytime the command is run and I also tried with a named item, same error. I haven't tried with enchantments.

@APickledWalrus
Copy link
Member

APickledWalrus commented Jul 21, 2020

Okay, I am going to investigate if this occurs on other versions.

EDIT 1: Reproduced on 1.16.1 Paper-89
EDIT 2: Seems to occur with any ItemType

@APickledWalrus APickledWalrus added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. priority: critical For issues causing catastrophic failure for some or many users. Should be fixed ASAP. and removed priority: high Issues with potentially high impact that could be harmful to users. needs testing Needs testing to determine current status or issue validity, or for WIP feature pulls. labels Jul 21, 2020
@APickledWalrus
Copy link
Member

Can someone confirm whether this issue is present on alpha5?

@TPGamesNL
Copy link
Member Author

TPGamesNL commented Jul 21, 2020

This issue is not present on alpha5 (1.15.2, paper-379)

@Romitou
Copy link
Member

Romitou commented Jul 21, 2020

I can confirm this issue only with 2.5-alpha6 on Paper 1.15.2.

@APickledWalrus
Copy link
Member

APickledWalrus commented Jul 22, 2020

I believe the cause of this issue has been found, it just needs to be patched.

@APickledWalrus APickledWalrus added priority: high Issues with potentially high impact that could be harmful to users. and removed priority: critical For issues causing catastrophic failure for some or many users. Should be fixed ASAP. labels Jul 25, 2020
@APickledWalrus
Copy link
Member

Going to downgrade this since it doesn't affect the current release. It must be fixed for the next release though.

@ShaneBeee ShaneBeee added the completed The issue has been fully resolved and the change will be in the next Skript update. label Aug 6, 2020
@ShaneBeee
Copy link
Contributor

Marking this as completed and closing.
Im not sure why this was missed but it was fixed in 2.5-beta1

@TPGamesNL
Copy link
Member Author

Why exactly was this closed? I know that this specific case is no longer present in the latest release, but the underlying issue with Yggdrasil's serializer is still present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. priority: high Issues with potentially high impact that could be harmful to users.
Projects
None yet
Development

No branches or pull requests

5 participants