Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExprScripts: PatternSyntaxException #3193

Closed
Romitou opened this issue Jul 22, 2020 · 3 comments
Closed

ExprScripts: PatternSyntaxException #3193

Romitou opened this issue Jul 22, 2020 · 3 comments
Assignees
@APickledWalrus
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation).

Comments

@Romitou
Copy link
Member

Romitou commented Jul 22, 2020 •
edited
Loading

Description

An error is displayed in the console when I use the expression scripts.

Steps to Reproduce

Just run send "%scripts%".

Expected Behavior

There should be no error.

Errors / Screenshots

https://gist.github.com/Romitou/f7685d189b8735eec9e500b56d530fad

Server Information

  • Server version/platform: git-Spigot-800b93f-8160e29 (MC: 1.15.2)
  • Skript version: tested with 2.5-alpha5 and 2.5-alpha6 (I forgot to test with 2.5-alpha6(rev1), but the error is finally the same).
@Romitou Romitou changed the title : ExprScripts: PatternSyntaxException ExprScripts: PatternSyntaxException Jul 22, 2020
@TPGamesNL
Copy link
Member

TPGamesNL commented Jul 22, 2020 •
edited
Loading

This is caused by ExprScripts using String#replaceFirst with the intention of the first argument being a normal string, but it is actually parsed as regex: https://github.com/SkriptLang/Skript/blob/master/src/main/java/ch/njol/skript/expressions/ExprScripts.java#L87

@APickledWalrus APickledWalrus added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation). labels Jul 22, 2020
@APickledWalrus APickledWalrus self-assigned this Jul 22, 2020
@APickledWalrus APickledWalrus mentioned this issue Jul 22, 2020
Merged
@APickledWalrus
Copy link
Member

APickledWalrus commented Jul 22, 2020 •
edited
Loading

Should be fixed in #3194, and you are welcome to test out the nighty-build to find out (https://github.com/SkriptLang/Skript/suites/952837183/artifacts/11903429). However, the nightly build will contain the serious #3185 bug, just so that you are aware.

APickledWalrus added a commit that referenced this issue Jul 23, 2020
@APickledWalrus
Fix PatternSyntaxException (#3194)
deb75ac 
#3193
@Whimsyturtle Whimsyturtle added the completed The issue has been fully resolved and the change will be in the next Skript update. label Jul 23, 2020
@Romitou
Copy link
Member Author

Romitou commented Jul 23, 2020 •
edited
Loading

Thank you for the fix! 😄
It's working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@APickledWalrus APickledWalrus

Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Whimsyturtle @ShaneBeee @APickledWalrus @TPGamesNL @Romitou