Fix NotSerializableException #3346
Conversation
Also enables Relational Variables again
APickledWalrus
added
the
bug
Seems to work without issue, but prints an error stating that PersistentDataHolder's'serializeAs' class is not serializable
|
This fix should work better than the last (no variable loading issue). However, I don't know if this solution is safe *will it cause other issues?). |
| @@ -113,7 +113,7 @@ public static void onRegistrationsStop() { | |||
| final ClassInfo<?> sa = getExactClassInfo(ci.getSerializeAs()); | |||
| if (sa == null) { | |||
| Skript.error(ci.getCodeName() + "'s 'serializeAs' class is not registered"); | |||
| } else if (sa.getSerializer() == null) { | |||
| } else if (sa.getSerializer() == null && ci.getSerializeAs() != Object.class) { | |||
There was a problem hiding this comment.
do you think it would be a good idea to only evaluate this second part if persistent data exists? it may help limit impact if this ends up causing a different issue
There was a problem hiding this comment.
I don’t think it will matter really. No other ClassInfos should really be using Object here unless they encounter this specific issue. Maybe I’m misunderstanding what you mean though?
|
Setting this to target 2.6 for now, as I want to do more extensive testing. |
|
reopening & updating this because I made a new fork |
Description
This PR fixes the NotSerializableException when PersistentDataHolder is a registered ClassInfo. Relational Variables are also re-enabled.
I'm not sure whether this is a good solution or if my terminology is correct haha - so let me know ;DThe check will throw an assertion error, but that doesn't seem to be related to this.
EDIT: Marking this as a draft for now because there are still some related issues.Target Minecraft Versions: 1.14+
Requirements: None
Related Issues: #3185