Skip to content
This repository has been archived by the owner on Jun 14, 2023. It is now read-only.

Make plugins support correlation protocol #15

Merged
merged 1 commit into from
Mar 18, 2021
Merged

Make plugins support correlation protocol #15

merged 1 commit into from
Mar 18, 2021

Conversation

mrproliu
Copy link
Contributor

Follow SkyAPM/go2sky#91 (comment), Support correlation context protocol to go2sky plugins.

@wu-sheng wu-sheng requested a review from arugal March 14, 2021 16:21
@wu-sheng wu-sheng added this to the 1.0.0 milestone Mar 14, 2021
@wu-sheng wu-sheng added the enhancement New feature or request label Mar 14, 2021
@arugal
Copy link
Member

arugal commented Mar 16, 2021

LGTM, please give me some time to release go2sky 1.0.0, I've been a little busy lately :)

@wu-sheng
Copy link
Member

@arugal I think we should merge this first, and update the dependency again after the release happens? Otherwise, this project's current master is not working with the latest core.

@arugal
Copy link
Member

arugal commented Mar 18, 2021

@arugal I think we should merge this first, and update the dependency again after the release happens? Otherwise, this project's current master is not working with the latest core.

Agree :)

Copy link
Member

@arugal arugal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @mrproliu please update the commitid in E2E :)

@arugal arugal merged commit c868b86 into SkyAPM:master Mar 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants