Skip to content
This repository has been archived by the owner on Jun 14, 2023. It is now read-only.

Support correlation #91

Merged
merged 5 commits into from
Mar 14, 2021
Merged

Support correlation #91

merged 5 commits into from
Mar 14, 2021

Conversation

mrproliu
Copy link
Contributor

@mrproliu mrproliu commented Mar 7, 2021

Support correlation custom data to tracing context.

@codecov-io
Copy link

codecov-io commented Mar 7, 2021

Codecov Report

Merging #91 (2a8ae15) into master (f4f82c8) will decrease coverage by 0.67%.
The diff coverage is 58.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #91      +/-   ##
==========================================
- Coverage   67.02%   66.34%   -0.68%     
==========================================
  Files          13       14       +1     
  Lines         561      621      +60     
==========================================
+ Hits          376      412      +36     
- Misses        151      170      +19     
- Partials       34       39       +5     
Impacted Files Coverage Δ
propagation/propagation.go 50.53% <37.77%> (-11.97%) ⬇️
correlation.go 85.71% <85.71%> (ø)
plugins/http/client.go 48.78% <100.00%> (ø)
plugins/http/server.go 50.00% <100.00%> (ø)
segment.go 91.01% <100.00%> (+0.31%) ⬆️
trace.go 80.00% <100.00%> (+1.64%) ⬆️
trace_opts.go 53.33% <0.00%> (+26.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4f82c8...2a8ae15. Read the comment docs.

@wu-sheng wu-sheng added this to the 1.0.0 milestone Mar 7, 2021
@wu-sheng wu-sheng added the enhancement New feature or request label Mar 7, 2021
@wu-sheng
Copy link
Member

wu-sheng commented Mar 7, 2021

This PR breaks the existing propagation APIs, but it is reasonable. @kezhenxu94 @arugal @hanahmily please review the codes detail.

@wu-sheng
Copy link
Member

wu-sheng commented Mar 7, 2021

We need to make the API stable before the 1.0 release.

@wu-sheng
Copy link
Member

wu-sheng commented Mar 7, 2021

@mrproliu I think this PR would break all plugins in https://github.com/SkyAPM/go2sky-plugins as most of them are going context propagation. You need to update those after this merges.

@mrproliu
Copy link
Contributor Author

mrproliu commented Mar 7, 2021

@mrproliu I think this PR would break all plugins in https://github.com/SkyAPM/go2sky-plugins as most of them are going context propagation. You need to update those after this merges.

Of course. After this merge, I will update the plugins.

README.md Outdated Show resolved Hide resolved
correlation.go Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@wu-sheng
Copy link
Member

@mrproliu Please update the plugins.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants