Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use server-based default ACL #83

Merged
merged 3 commits into from
Apr 7, 2017
Merged

Conversation

b123400
Copy link
Contributor

@b123400 b123400 commented Mar 28, 2017

@oursky-travis
Copy link

@b123400, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ben181231, @cheungpat and @limouren to be potential reviewers.

@cheungpat
Copy link
Contributor

@b123400 I just want to let you know that the PR needs changes because of lint check errors.

@b123400
Copy link
Contributor Author

b123400 commented Mar 29, 2017

This is interesting, I didn't edit any swift file and swiftlint's failing

@cheungpat
Copy link
Contributor

This is interesting, I didn't edit any swift file and swiftlint's failing

If this happens, this is usually caused by updated swiftlint version which might have additional checks for swift code. To verify that this happened. Trigger a rebuild on the master branch at travis and then make additional pull request to fix the lint errors. Then rebase this pull request.

@cheungpat
Copy link
Contributor

@b123400 Would be great if you could fix the lint on the master branch first.

@b123400
Copy link
Contributor Author

b123400 commented Mar 29, 2017

OK, I guess it will take some time

@cheungpat
Copy link
Contributor

I will merge this pull request after SkygearIO/skygear-server#329 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants