This repository has been archived by the owner on Dec 22, 2023. It is now read-only.
Make default ACL server-based #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@b123400, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ben181231, @cheungpat and @limouren to be potential reviewers. |
|
@b123400 Make sure that your PR title and comment is public consumable because the PR title and comment is usually included in the merge commit. Specifically “a server side thing” is not good for public understanding, though I totally understand what you are talking about. |
b123400
changed the title
b123400
changed the title
ben181231
suggested changes
Apr 6, 2017
pkg/server/handler/schema.go
Outdated
| for _, v := range payload.RawDefaultAccess { | ||
| ace := skydb.RecordACLEntry{} | ||
| if err := (*skyconv.MapACLEntry)(&ace).FromMap(v); err != nil { | ||
| return skyerr.NewInvalidArgument("invalid _default_access entry", []string{"_default_access"}) |
There was a problem hiding this comment.
The argument name should be default_access, right?
| CREATE TABLE _record_default_access ( | ||
| record_type text NOT NULL, | ||
| default_access jsonb, | ||
| UNIQUE (record_type, default_access) |
There was a problem hiding this comment.
The unique constraint should be on record_type only ?
|
@b123400 @rickmak @cheungpat Do we need a default ACL for all record types ? |
|
Updated to fix the issue |
ben181231
approved these changes
Apr 7, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connect #309
Client side needs update as well