Skip to content
This repository has been archived by the owner on Dec 22, 2023. It is now read-only.

Unable to connect to websocket #291

Closed
cheungpat opened this issue Feb 14, 2017 · 0 comments
Closed

Unable to connect to websocket #291

cheungpat opened this issue Feb 14, 2017 · 0 comments
Assignees

Comments

@cheungpat
Copy link
Contributor

The error is this “http: Hijack is incompatible with use of CloseNotifier in same ServeHTTP call”.

@cheungpat cheungpat self-assigned this Feb 14, 2017
cheungpat added a commit to cheungpat/skygear-server that referenced this issue Feb 14, 2017
The CloseNotifier is in conflict with the Hijacker interface (they
cannot be used at the same time). The context will not be cancelled when
the close channel from CloseNotifier is called. This is because the behavior
is not well understood. We can introduce it later if it poses a real problem.

refs SkygearIO#291
rickmak pushed a commit that referenced this issue Feb 15, 2017
The CloseNotifier is in conflict with the Hijacker interface (they
cannot be used at the same time). The context will not be cancelled when
the close channel from CloseNotifier is called. This is because the behavior
is not well understood. We can introduce it later if it poses a real problem.

refs #291
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant