This repository has been archived by the owner on Dec 22, 2023. It is now read-only.
Remove CloseNotifier #290
Closed
Remove CloseNotifier #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CloseNotifier is in conflict with the Hijacker interface (they cannot be used at the same time). The context will not be cancelled when the close channel from CloseNotifier is called. This is because the behavior is not well understood. We can introduce it later if it poses a real problem. refs SkygearIO#291
cheungpat
force-pushed
the
remove-closenotifier
branch
from
7059fb3 to
42896f4
Compare
|
Merge via b1a2c5e |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CloseNotifier is in conflict with the Hijacker interface (they
cannot be used at the same time). The context will not be cancelled when
the close channel from CloseNotifier is called. This is because the behavior
is not well understood. We can introduce it later if it poses a real problem.
connects #291