Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds update-prs with close feature #72

Merged
merged 4 commits into from
Jun 27, 2022
Merged

Adds update-prs with close feature #72

merged 4 commits into from
Jun 27, 2022

Conversation

sledigabel
Copy link
Contributor

Relates to #65
Fixes #60
Relates to #67

This PR implements a global PR closing command.
It introduces a new update-prs verb which has only one option
at the moment: --close.

It uses the same mechanism as in #67, looking at the PRs and identifying
the one related to the campain, then closes it.

It handles the case where there is no open PR.

Relates to #65
Fixes #60
Relates to #67

This PR implements a global PR closing command.
It introduces a new `update-prs` verb which has only one option
at the moment: `--close`.

It uses the same mechanism as in #67, looking at the PRs and identifying
the one related to the campain, then closes it.

It handles the case where there is no open PR.
@sledigabel sledigabel requested a review from rnorth January 26, 2022 12:08
@rnorth rnorth mentioned this pull request Apr 24, 2022
3 tasks
@rnorth
Copy link
Collaborator

rnorth commented Apr 24, 2022

Please could we have an update to the README?

Copy link
Collaborator

@rnorth rnorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of minor comments and the request for something in the README, but LGTM!

- typos
- Readme addition

Signed-off-by: Sebastien Le Digabel <sledigabel@gmail.com>
@rnorth rnorth merged commit dea079b into main Jun 27, 2022
@rnorth rnorth deleted the close-prs branch June 27, 2022 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Close all created PRs
2 participants