Add pr-status command

[rnorth]

• Upgrade golangci-lint (builds upon Upgrade golangci-lint #66)
• Draft: pr-status command

Fixes #18, #26
Alternative solution to #58

Example:

$ turbolift pr-status --list
  OK   Reading campaign data
  OK   Checking PR status for rnorth/turbolift-play-1
  OK   Checking PR status for rnorth/turbolift-play-2
 WARN  Checking PR status for rnorth/turbolift-play-3: Directory work/rnorth/turbolift-play-3 does not exist - has it been cloned?

  OK   turbolift pr-status completed


Repository               State   Reviews  URL
rnorth/turbolift-play-1  OPEN             https://github.com/rnorth/turbolift-play-1/pull/1
rnorth/turbolift-play-2  CLOSED           https://github.com/rnorth/turbolift-play-2/pull/1

State      Count
Merged     0
Open       1
Closed     1
Skipped    1
Not Found  0

Reaction  Count
👍         1
👎         2

TODO:

• Tidy up presentation
• Add review status
• ???

[rnorth]

@sledigabel @JimNero009 what do you think?

[sledigabel]

just some tiny comments, overall I'm loving it :-)

[rnorth]

Updated output:

$ turbolift pr-status
  OK   Reading campaign data
  OK   Checking PR status for rnorth/turbolift-play-1
  OK   Checking PR status for rnorth/turbolift-play-2
  OK   turbolift pr-status completed


State      Count
Merged     0
Open       2
Closed     0
Skipped    0
Not Found  0

Reactions: 👍 1   🎉 1   ❤️ 1

[rnorth]

@sledigabel Ah for verifying the review status column, I think we'll need to run this against repos where someone can approve a PR. I have some private repos for playing in, but obviously can't approve my own PRs there 😂

[sledigabel]

A few comments, overall it looks great, well done @rnorth !

[rnorth]

Marked as draft until #72 is in.

[rnorth]

Ah, the GetPR function refuses to return a PR which has status closed - which is a problem, as merged PRs now come back with a No PR Found error.

@sledigabel do you remember if there's such a strong need for GetPR to filter out closed PRs?

i.e. in:

    // if the user has write permissions on the repo,
	// the PR should be under _CurrentBranch_.
	if prr.CurrentBranch != nil && !prr.CurrentBranch.Closed {
		return prr.CurrentBranch, nil
	}

	// If not, then it's a forked PR. The headRefName is as such: `username:branchName`
	for _, pr := range prr.CreatedBy {
		if strings.HasSuffix(pr.HeadRefName, branchName) && !pr.Closed {
			return pr, nil
		}
	}

	return nil, &NoPRFoundError{Path: workingDir, BranchName: branchName}

This code is rejecting the below status response, for example:

{
  "createdBy": [],
  "currentBranch": {
    "closed": true,
    "headRefName": "xxxx",
    "mergeable": "UNKNOWN",
    "number": 88,
    "reactionGroups": [],
    "reviewDecision": "APPROVED",
    "state": "MERGED",
    "title": "xxxx",
    "url": "xxxx/pull/88"
  },
  "needsReview": []
}

[sledigabel]

@rnorth Upon a very late check, I don't think the pr.Closed check is required at all.
The expectation when GetPR came up was that the PR would be non existant or open I think.
I believe it can be safely removed.

[rnorth]

Awesome, thanks for clarifying @sledigabel!

[rnorth]

Now producing far more sensible output, e.g:

...
  OK   turbolift pr-status completed


State        Count
Merged       139
Open         53
Closed       29
Skipped      0
No PR Found  1

[rnorth]

The --list mode looks pretty reasonable, I think, too:

...
  OK   turbolift pr-status completed


Repository                                                State   Reviews            URL
redacted/redacted                                         OPEN    REVIEW_REQUIRED    https://github.redacted/redacted/redacted/pull/262
redacted/redacted                                         OPEN    REVIEW_REQUIRED    https://github.redacted/redacted/redacted/pull/515
redacted/redacted                                         OPEN    REVIEW_REQUIRED    https://github.redacted/redacted/redacted/pull/342
redacted/redacted                                         MERGED  APPROVED           https://github.redacted/redacted/redacted/pull/407
redacted/redacted                                         MERGED  REVIEW_REQUIRED    https://github.redacted/redacted/redacted/pull/220
redacted/redacted                                         OPEN    REVIEW_REQUIRED    https://github.redacted/redacted/redacted/pull/105
redacted/redacted                                         MERGED  APPROVED           https://github.redacted/redacted/redacted/pull/532
redacted/redacted                                         MERGED  APPROVED           https://github.redacted/redacted/redacted/pull/268
redacted/redacted                                         OPEN    REVIEW_REQUIRED    https://github.redacted/redacted/redacted/pull/438
...

[catscanner]

adds a command to show the current state of turbolift raised prs