Optional repo file #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sledigabel
commented
Feb 16, 2022
sledigabel
commented
Feb 16, 2022
rnorth
reviewed
Apr 24, 2022
rnorth
reviewed
Apr 24, 2022
sledigabel
force-pushed
the
repo_selection
branch
from
af5d0bb to
ca4b482
Compare
|
I guess we should also mention this in the README! |
Fixes #74 Adds a new flag for all commands `--repos=<filename>`, which gives the ability to select a different file from the default `repos.txt` one.
- Changed error text to include filename last Signed-off-by: Sebastien Le Digabel <sledigabel@gmail.com>
sledigabel
force-pushed
the
repo_selection
branch
from
ca4b482 to
5ee11c7
Compare
The `pr-status` command was added after and needed the extra danse to include the new repo file option. Also renamed the `pr_status` package into `prstatus` as gofumpt told me packages should not include underscores. https://go.dev/blog/package-names
.. addressing the PR comment. Also renamed the update_prs package name for the same reason as the pr_status one.
|
There's an issue with foreach, the flags aren't parsed (because of the disabledParsing, as expected) |
Adding a manual parsing of the foreach parameters and extra testing. Also added some details in the Readme
sledigabel
commented
May 25, 2023
sledigabel
commented
May 25, 2023
This is now resolved, but adding a manual parsing of the arguments for foreach. |
olliecurtis
approved these changes
Jun 15, 2023
Dan7-7-7
approved these changes
Jun 15, 2023
rnorth
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #74
Adds a new flag for all commands
--repos=<filename>, which gives theability to select a different file from the default
repos.txtone.