-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add gemeni pro support #1307
add gemeni pro support #1307
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 3229498 in 15 seconds
More details
- Looked at
66
lines of code in3
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. skyvern/forge/sdk/api/llm/config_registry.py:250
- Draft comment:
Gemini is not included in the initial provider check (around line 54). Addsettings.ENABLE_GEMINI
to ensure the check accounts for Gemini being enabled. - Reason this comment was not posted:
Comment was not on a valid diff hunk.
Workflow ID: wflow_s4FO2uNYw3zjXG4a
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
3229498
to
5f6eaf1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 5f6eaf1 in 11 seconds
More details
- Looked at
74
lines of code in3
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. setup.sh:102
- Draft comment:
Fix the typo in 'Configuartion'.
# Gemini Configuration
- Reason this comment was not posted:
Confidence changes required:10%
The comment on line 102 in setup.sh has a typo in the word 'Configuration'.
Workflow ID: wflow_3RmFrfTUAwG3c2e8
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
5f6eaf1
to
0d47799
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 0d47799 in 10 seconds
More details
- Looked at
95
lines of code in4
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. setup.sh:101
- Draft comment:
Typo in comment: 'Configuartion' should be 'Configuration'. - Reason this comment was not posted:
Confidence changes required:10%
The word 'Configuartion' is misspelled in the comment. It should be 'Configuration'.
Workflow ID: wflow_Yv5eeRrfkfWt9WNz
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
update: #1308 |
Important
Adds support for Gemini language model provider, including configuration and registration for
GEMINI_PRO
.GEMINI_PRO
model.setup.sh
to include Gemini configuration prompts and environment variable setup.ENABLE_GEMINI
andGEMINI_API_KEY
to.env.example
.GEMINI_PRO
inconfig_registry.py
with vision support and max output tokens of 8192.README.md
to include Gemini in supported LLMs and environment variables.This description was created by for 0d47799. It will automatically update as commits are pushed.