Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add gemeni pro support #1307

Merged
merged 1 commit into from
Dec 2, 2024
Merged

add gemeni pro support #1307

merged 1 commit into from
Dec 2, 2024

Conversation

wintonzheng
Copy link
Contributor

@wintonzheng wintonzheng commented Dec 2, 2024

Important

Adds support for Gemini language model provider, including configuration and registration for GEMINI_PRO.

  • Behavior:
    • Adds support for Gemini as a language model provider with GEMINI_PRO model.
    • Updates setup.sh to include Gemini configuration prompts and environment variable setup.
  • Configuration:
    • Adds ENABLE_GEMINI and GEMINI_API_KEY to .env.example.
    • Registers GEMINI_PRO in config_registry.py with vision support and max output tokens of 8192.
  • Documentation:
    • Updates README.md to include Gemini in supported LLMs and environment variables.

This description was created by Ellipsis for 0d47799. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 3229498 in 15 seconds

More details
  • Looked at 66 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern/forge/sdk/api/llm/config_registry.py:250
  • Draft comment:
    Gemini is not included in the initial provider check (around line 54). Add settings.ENABLE_GEMINI to ensure the check accounts for Gemini being enabled.
  • Reason this comment was not posted:
    Comment was not on a valid diff hunk.

Workflow ID: wflow_s4FO2uNYw3zjXG4a


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 5f6eaf1 in 11 seconds

More details
  • Looked at 74 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. setup.sh:102
  • Draft comment:
    Fix the typo in 'Configuartion'.
    # Gemini Configuration
  • Reason this comment was not posted:
    Confidence changes required: 10%
    The comment on line 102 in setup.sh has a typo in the word 'Configuration'.

Workflow ID: wflow_3RmFrfTUAwG3c2e8


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 0d47799 in 10 seconds

More details
  • Looked at 95 lines of code in 4 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. setup.sh:101
  • Draft comment:
    Typo in comment: 'Configuartion' should be 'Configuration'.
  • Reason this comment was not posted:
    Confidence changes required: 10%
    The word 'Configuartion' is misspelled in the comment. It should be 'Configuration'.

Workflow ID: wflow_Yv5eeRrfkfWt9WNz


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@wintonzheng wintonzheng merged commit 57e6404 into main Dec 2, 2024
2 checks passed
@wintonzheng wintonzheng deleted the shu/gemini_support branch December 2, 2024 23:51
@wintonzheng
Copy link
Contributor Author

update: #1308

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant