gemini 1.5 pro & flash #1308
Merged
gemini 1.5 pro & flash #1308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 978b0cd in 36 seconds
More details
- Looked at
23lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern/forge/sdk/api/llm/config_registry.py:263
- Draft comment:
The configuration key "GEMINI_FLUSH" might be a typo. Consider renaming it to "GEMINI_FLASH" for consistency with the naming convention. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable:
The comment is addressing a potential inconsistency between the configuration key 'GEMINI_FLUSH' and the model name 'gemini/gemini-1.5-flash'. This could be a valid point if the naming convention is to match the key with the model name. However, without additional context on naming conventions, it's speculative. The comment is about a change made in the diff, so it is relevant.
I might be overestimating the importance of matching the configuration key with the model name. The naming might be intentional for reasons not visible in the diff.
Without clear evidence that the naming is intentional, it's reasonable to consider the comment as potentially valid. However, the lack of strong evidence means the comment might be speculative.
The comment is speculative and lacks strong evidence of an issue. It should be deleted as it does not meet the criteria for a necessary code change.
Workflow ID: wflow_SOF0Meli6WzHQCtK
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Merged
There was a problem hiding this comment.
❌ Changes requested. Incremental review on 0aee3c2 in 41 seconds
More details
- Looked at
14lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_UATD8vOAnHjwACgO
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| @@ -285,7 +285,8 @@ More extensive documentation can be found on our [documentation website](https:/ | |||
| | `ENABLE_AZURE` | Register Azure OpenAI models | Boolean | `true`, `false` | | |||
| | `ENABLE_BEDROCK` | Register AWS Bedrock models| Boolean | `true`, `false` | | |||
| | `ENABLE_GEMINI` | Register Gemini models| Boolean | `true`, `false` | | |||
| | `LLM_KEY` | The name of the model you want to use | String | Currently supported llm keys: `OPENAI_GPT4_TURBO`, `OPENAI_GPT4V`, `OPENAI_GPT4O`, `OPENAI_GPT4O_MINI`, `ANTHROPIC_CLAUDE3`, `ANTHROPIC_CLAUDE3_OPUS`, `ANTHROPIC_CLAUDE3_SONNET`, `ANTHROPIC_CLAUDE3_HAIKU`, `ANTHROPIC_CLAUDE3.5_SONNET`, `BEDROCK_ANTHROPIC_CLAUDE3_OPUS`, `BEDROCK_ANTHROPIC_CLAUDE3_SONNET`, `BEDROCK_ANTHROPIC_CLAUDE3_HAIKU`, `BEDROCK_ANTHROPIC_CLAUDE3.5_SONNET`, `AZURE_OPENAI` | | |||
| | `LLM_KEY` | The name of the model you want to use | String | Currently supported llm keys: `OPENAI_GPT4_TURBO`, `OPENAI_GPT4V`, `OPENAI_GPT4O`, `OPENAI_GPT4O_MINI`, `ANTHROPIC_CLAUDE3`, `ANTHROPIC_CLAUDE3_OPUS`, `ANTHROPIC_CLAUDE3_SONNET`, `ANTHROPIC_CLAUDE3_HAIKU`, `ANTHROPIC_CLAUDE3.5_SONNET`, `BEDROCK_ANTHROPIC_CLAUDE3_OPUS`, `BEDROCK_ANTHROPIC_CLAUDE3_SONNET`, `BEDROCK_ANTHROPIC_CLAUDE3_HAIKU`, `BEDROCK_ANTHROPIC_CLAUDE3.5_SONNET`, `AZURE_OPENAI`, `GEMINI_PRO`, `GEMINI_FLUSH`| | |||
There was a problem hiding this comment.
Typo: GEMINI_FLUSH should be GEMINI_FLASH for consistency with the configuration name gemini-1.5-flash. This typo is also present in the SECONDARY_LLM_KEY description.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Add configurations for
gemini-1.5-proandgemini-1.5-flashmodels with vision support and update README.GEMINI_PROconfiguration forgemini-1.5-prowithsupports_vision=Trueandmax_output_tokens=8192inconfig_registry.py.GEMINI_FLUSHconfiguration forgemini-1.5-flashwithsupports_vision=Trueandmax_output_tokens=8192inconfig_registry.py.README.mdto includeGEMINI_PROandGEMINI_FLUSHin the list of supported LLM keys.This description was created by
for 0aee3c2. It will automatically update as commits are pushed.