Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change order of information in timeline info section #1438

Merged
merged 1 commit into from
Dec 25, 2024

Conversation

wintonzheng
Copy link
Contributor

@wintonzheng wintonzheng commented Dec 25, 2024

Important

Reorders tabs and changes default tab logic in WorkflowRunTimelineItemInfoSection based on item status.

  • Behavior:
    • Changes default tab logic in WorkflowRunTimelineItemInfoSection to prioritize extracted_information if status is Completed, otherwise failure_reason if status is a failure type, else navigation_goal.
    • Reorders TabsTrigger for navigation_goal to appear after failure_reason and extracted_information.
  • UI:
    • Adjusts Tabs component in WorkflowRunTimelineItemInfoSection to reflect new tab order and default selection logic.

This description was created by Ellipsis for 8c993fd. It will automatically update as commits are pushed.

…src/'

<!-- ELLIPSIS_HIDDEN -->

> [!IMPORTANT]
> Reorders tabs and changes default tab logic in `WorkflowRunTimelineItemInfoSection` based on item status.
>
>   - **Behavior**:
>     - Changes default tab logic in `WorkflowRunTimelineItemInfoSection` to prioritize `extracted_information` if status is `Completed`, otherwise `failure_reason` if status is a failure type, else `navigation_goal`.
>     - Reorders `TabsTrigger` for `navigation_goal` to appear after `failure_reason` and `extracted_information`.
>   - **UI**:
>     - Adjusts `Tabs` component in `WorkflowRunTimelineItemInfoSection` to reflect new tab order and default selection logic.
>
> <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for 49766f9027235a9bde45c9190a72a57bb821352a. It will automatically update as commits are pushed.</sup>

<!-- ELLIPSIS_HIDDEN -->
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 8c993fd in 7 seconds

More details
  • Looked at 59 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/workflowRun/WorkflowRunTimelineItemInfoSection.tsx:59
  • Draft comment:
    Consider extracting the logic for determining defaultTab into a separate function to improve readability and maintainability.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The logic for determining the default tab is repeated in multiple places. It would be more maintainable to extract this logic into a separate function.

Workflow ID: wflow_94hlK9wZzjImQsni


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 8c993fd in 21 seconds

More details
  • Looked at 59 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/workflowRun/WorkflowRunTimelineItemInfoSection.tsx:53
  • Draft comment:
    hasExtractedInformation is imported but never used. Consider removing it to clean up the code.
  • Reason this comment was not posted:
    Confidence changes required: 10%
    The import statement for hasExtractedInformation is unnecessary as it is not used in the code.

Workflow ID: wflow_SFdGjJ1WbIavZm0h


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@msalihaltun msalihaltun merged commit caf25a4 into main Dec 25, 2024
2 checks passed
@msalihaltun msalihaltun deleted the salih/change-info-order-in-timeline branch December 25, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants