Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change order of information in timeline info section #1438

Merged
merged 1 commit into from
Dec 25, 2024
Merged

Change order of information in timeline info section #1438

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions skyvern-frontend/src/routes/workflows/workflowRun/WorkflowRunTimelineItemInfoSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,14 @@ function WorkflowRunTimelineItemInfoSection({ activeItem }: Props) {
);
}
if (isWorkflowRunBlock(item)) {
const showExtractedInformationTab = item.status === Status.Completed;
const showFailureReasonTab =
item.status && statusIsAFailureType({ status: item.status });
const defaultTab = showExtractedInformationTab
? "extracted_information"
: showFailureReasonTab
? "failure_reason"
: "navigation_goal";
if (
item.block_type === WorkflowBlockTypes.Task ||
item.block_type === WorkflowBlockTypes.Navigation ||
Expand All @@ -64,9 +72,8 @@ function WorkflowRunTimelineItemInfoSection({ activeItem }: Props) {
) {
return (
<div className="rounded bg-slate-elevation1 p-4">
<Tabs key={item.block_type} defaultValue="navigation_goal">
<Tabs key={item.block_type} defaultValue={defaultTab}>
<TabsList>
<TabsTrigger value="navigation_goal">Navigation Goal</TabsTrigger>
{item.status === Status.Completed && (
<TabsTrigger value="extracted_information">
Extracted Information
Expand All @@ -75,14 +82,9 @@ function WorkflowRunTimelineItemInfoSection({ activeItem }: Props) {
{item.status && statusIsAFailureType({ status: item.status }) && (
<TabsTrigger value="failure_reason">Failure Reason</TabsTrigger>
)}
<TabsTrigger value="navigation_goal">Navigation Goal</TabsTrigger>
<TabsTrigger value="parameters">Parameters</TabsTrigger>
</TabsList>
<TabsContent value="navigation_goal">
<AutoResizingTextarea
value={item.navigation_goal ?? ""}
readOnly
/>
</TabsContent>
{item.status === Status.Completed && (
<TabsContent value="extracted_information">
<CodeEditor
Expand Down Expand Up @@ -112,6 +114,12 @@ function WorkflowRunTimelineItemInfoSection({ activeItem }: Props) {
/>
</TabsContent>
)}
<TabsContent value="navigation_goal">
<AutoResizingTextarea
value={item.navigation_goal ?? ""}
readOnly
/>
</TabsContent>
<TabsContent value="parameters">
<CodeEditor
value={JSON.stringify(item.navigation_payload, null, 2)}
Expand Down
Loading