Add created at to workflow runs table #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src/' <!-- ELLIPSIS_HIDDEN --> | 🚀 | This description was created by [Ellipsis](https://www.ellipsis.dev) for commit f6bc5e993ac09951a9a18b2c91bfde50b76a1281 | |--------|--------| ### Summary: Added 'Created At' column to workflow runs table in `Workflows` component, displaying formatted creation time. **Key points**: - Added 'Created At' column to workflow runs table in `skyvern-frontend/src/routes/workflows/Workflows.tsx`. - Utilized `basicTimeFormat` from `@/util/timeFormat` to format the creation time. - Adjusted column widths and colspan values to accommodate the new column. ---- Generated with ❤️ by [ellipsis.dev](https://www.ellipsis.dev) <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to f142364 in 26.262783 seconds
More details
- Looked at
67lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/Workflows.tsx:160
- Draft comment:
Ensure that the new column widths are balanced and provide a good user experience. Consider testing with various screen sizes and content lengths to verify that the table remains readable and functional. - Reason this comment was not posted:
Confidence changes required:33%
The PR adds a new column 'Created At' to the workflow runs table. The column widths have been adjusted to accommodate the new column. The new column uses thebasicTimeFormatfunction to format the creation time of each workflow run. The PR seems to correctly implement the feature as described in the PR description. However, the column width adjustments might need a review to ensure they are balanced and provide a good user experience.
Workflow ID: wflow_KE6ZWwMHsus6vmh9
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
❌ Changes requested. Incremental review on f142364 in 1.0 minute and 8.122022000000001 seconds
More details
- Looked at
66lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_AWudgo4cPH1QYgw7
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| <TableHead className="w-1/4">Status</TableHead> | ||
| <TableHead className="w-1/5">Workflow Run ID</TableHead> | ||
| <TableHead className="w-1/7">Status</TableHead> | ||
| <TableHead className="w-1/4">Created At</TableHead> |
There was a problem hiding this comment.
The total width of the columns now exceeds 100%, which can cause layout issues. Please adjust the column widths so that their combined width sums up to 100%.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Added 'Created At' column to workflow runs table in
Workflowscomponent, displaying formatted creation time.Key points:
skyvern-frontend/src/routes/workflows/Workflows.tsx.basicTimeFormatfrom@/util/timeFormatto format the creation time.Generated with ❤️ by ellipsis.dev