Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add created at to workflow runs table #645

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Add created at to workflow runs table #645

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions skyvern-frontend/src/routes/workflows/Workflows.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import {
} from "@/components/ui/pagination";
import { cn } from "@/util/utils";
import { WorkflowTitle } from "./WorkflowTitle";
import { basicTimeFormat } from "@/util/timeFormat";

function Workflows() {
const credentialGetter = useCredentialGetter();
Expand Down Expand Up @@ -152,20 +153,21 @@ function Workflows() {
<Table>
<TableHeader>
<TableRow>
<TableHead className="w-1/4">Workflow ID</TableHead>
<TableHead className="w-1/5">Workflow ID</TableHead>
<TableHead className="w-1/4">Workflow Title</TableHead>
<TableHead className="w-1/4">Workflow Run ID</TableHead>
<TableHead className="w-1/4">Status</TableHead>
<TableHead className="w-1/5">Workflow Run ID</TableHead>
<TableHead className="w-1/7">Status</TableHead>
<TableHead className="w-1/4">Created At</TableHead>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The total width of the columns now exceeds 100%, which can cause layout issues. Please adjust the column widths so that their combined width sums up to 100%.

</TableRow>
</TableHeader>
<TableBody>
{workflowRunsIsLoading ? (
<TableRow>
<TableCell colSpan={4}>Loading...</TableCell>
<TableCell colSpan={5}>Loading...</TableCell>
</TableRow>
) : workflowRuns?.length === 0 ? (
<TableRow>
<TableCell colSpan={4}>No workflow runs found</TableCell>
<TableCell colSpan={5}>No workflow runs found</TableCell>
</TableRow>
) : (
workflowRuns?.map((workflowRun) => {
Expand All @@ -179,20 +181,23 @@ function Workflows() {
}}
className="cursor-pointer"
>
<TableCell className="w-1/4">
<TableCell className="w-1/5">
{workflowRun.workflow_permanent_id}
</TableCell>
<TableCell className="w-1/4">
<WorkflowTitle
workflowPermanentId={workflowRun.workflow_permanent_id}
/>
</TableCell>
<TableCell className="w-1/4">
<TableCell className="w-1/5">
{workflowRun.workflow_run_id}
</TableCell>
<TableCell className="w-1/4">
<TableCell className="w-1/7">
<StatusBadge status={workflowRun.status} />
</TableCell>
<TableCell className="w-1/4">
{basicTimeFormat(workflowRun.created_at)}
</TableCell>
</TableRow>
);
})
Expand Down
Loading