Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(webui): Automatic ROI naming + ROI/Alignment marker position validation #99

Merged
merged 8 commits into from
Dec 13, 2023

Conversation

Slider0007
Copy link
Owner

@Slider0007 Slider0007 commented Dec 12, 2023

1. feat(webui): Automatic ROI naming

  • The ROI names for digit and analog ROIs are automatically and uniquely generated: e.g. dig1, dig2, ... | ana1, ana2, ...
    • No user-defined names anymore to avoid issues like wrong ROI image presentation on 'Recognition Details' page whenever identical ROI names are used multiple times in one number sequence (digit ROI image with same name than analog ROI is shown between analog ROIs)
    • Avoid confusion in terms of ROI value which is independent from ROI name but only from ROI position in drop-down
    • ROI name is not relevant for other purposees, only for user feedback
  • It is ensured that names are always in ascending order without any naming gap between even ROI are deleted between existing ones.

2. feat(webui): ROI & Alignment marker basic position validation

  • ROI & Alignment marker coordinates are checked against the image size (width & height) to ensure that ROI / Alignment Marker is not out of image area (check implemented on HTML + firmware level)
  • Detecting one or more ROIs out of image area firmware is aborting intialization step (+ error message in log) to prevent against processing without valid values.

3. feat(webui): Aligment marker histogram

  • Add a histogram of alignment marker image to eventually provide some support to find marker area with proper contrast.
    image

4. feat(webui): Reference image size validation

  • The size of actual reference image gets validated against the configured size. If the size differs a warning message will be displayed to indicate that a new reference image shall be taken.

5. feat(webui): Digit/Analog ROI: Add option to show only the selected ROI

6. refactor(webui): HTML / JS code cleanup, name and style harmonization

feat(webui): Basic ROI position validation

refactor(webui): ROI pages cleanup & style harmonization
feat(webui): Alignment marker histogram

refactor(webui): Alignment marker: code cleanup & harmonization
@Slider0007 Slider0007 changed the title feat(webui): Automatic ROI naming and position validation + Alignment marker position validation and histrogram; feat(webui): Automatic ROI naming and position validation, Alignment marker position validation and histrogram Dec 12, 2023
@Slider0007 Slider0007 changed the title feat(webui): Automatic ROI naming and position validation, Alignment marker position validation and histrogram feat(webui): Automatic ROI naming and position validation, Alignment marker position validation and image histrogram Dec 12, 2023
@Slider0007 Slider0007 changed the title feat(webui): Automatic ROI naming and position validation, Alignment marker position validation and image histrogram feat(webui): Automatic ROI naming + ROI / Alignment marker position validation + Alignment marker image histrogram Dec 12, 2023
@Slider0007 Slider0007 changed the title feat(webui): Automatic ROI naming + ROI / Alignment marker position validation + Alignment marker image histrogram feat(webui): Automatic ROI naming + ROI / Alignment marker position validation + Alignment marker histrogram Dec 12, 2023
@Slider0007 Slider0007 changed the title feat(webui): Automatic ROI naming + ROI / Alignment marker position validation + Alignment marker histrogram feat(webui): Automatic ROI naming + ROI/Alignment marker position validation + Alignment marker histrogram Dec 12, 2023
@Slider0007 Slider0007 changed the title feat(webui): Automatic ROI naming + ROI/Alignment marker position validation + Alignment marker histrogram feat(webui): Automatic ROI naming + ROI/Alignment marker position validation Dec 12, 2023
@Slider0007 Slider0007 marked this pull request as draft December 12, 2023 22:24
@Slider0007 Slider0007 marked this pull request as ready for review December 13, 2023 08:24
@Slider0007 Slider0007 merged commit cd5b979 into develop Dec 13, 2023
@Slider0007 Slider0007 deleted the webui-digit-analog-roi branch December 13, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant