Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button to hide other red Digit Frames for easier setup #2680

Closed
loewi1979 opened this issue Nov 2, 2023 · 10 comments · Fixed by #2907
Closed

Button to hide other red Digit Frames for easier setup #2680

loewi1979 opened this issue Nov 2, 2023 · 10 comments · Fixed by #2907
Labels
enhancement New feature or request

Comments

@loewi1979
Copy link

The Feature

For easier Setup it would be great, if there is a button on the Screen "Settings => Regions of Interrest => Digital ROI" that you can hide all other digits than the one which is setuped at the moment.
The red frames of all the digits overlap, so it is hard to see the actual confgigured digit-frame. If you could hide the other ones for setting up each digit by itself, and to show all the others for checking them all would be a great option.

@loewi1979 loewi1979 added the enhancement New feature or request label Nov 2, 2023
@jurasjo
Copy link

jurasjo commented Nov 3, 2023

It is a great idea!

@caco3
Copy link
Collaborator

caco3 commented Nov 3, 2023

The selected digit has a brighter red frame, so I am not sure if this really is needed:
grafik

@jurasjo
Copy link

jurasjo commented Nov 4, 2023

Unless, your meter is like this one...
image

@caco3
Copy link
Collaborator

caco3 commented Nov 4, 2023

I suggest to make the names of the ROIS smaller.

IMO it would be quite some effort to implement this feature without a real need to it.
But we are happy to receive contributions.

@SybexX
Copy link
Collaborator

SybexX commented Jan 8, 2024

If you feel like it, you can try it out.
I only tested it briefly^^

test.zip

Show-All-ROIs

@caco3
Copy link
Collaborator

caco3 commented Jan 8, 2024

Could you create a Pull request?
That would be easier to see the changes and to test it.

@caco3 caco3 linked a pull request Feb 15, 2024 that will close this issue
caco3 pushed a commit that referenced this issue Feb 15, 2024
Button to hide other red Digit Frames for easier setup, implements #2680
@caco3
Copy link
Collaborator

caco3 commented Feb 15, 2024

Thanks!
I will modify the UI a bit and invert the text -> "hide other ROIs"

@SybexX
Copy link
Collaborator

SybexX commented Feb 15, 2024

ich würde die Werte von Aec2 = true und FixedExposure = true in der config.ini ändern, dann hat man annähernd die Bildqualität die vor den Änderungen war

@caco3
Copy link
Collaborator

caco3 commented Feb 15, 2024

kannst Du einen PR machen?, wäre cool

@caco3
Copy link
Collaborator

caco3 commented Feb 15, 2024

Bin auch am überlegen, beim ersten start der neuen version ein banner anzuzeigen, dass man die einstellungen überprüft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants