-
-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tracker reset logic #1150
Fix tracker reset logic #1150
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This’ll change behaviour. You should just set the Autobone trackers as internal if you don’t want them reset as that’s what they are
If I set it to internal, then HumanSkeleton won't accept it. It's not internal anyways, that's not what that flag was supposed to mean. And why should the default behaviour be ignoring the |
IIRC it’s because the HMD has the needReset flag to false. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good for old behaviour and Autobone seems to work (both tested)
The tracker reset logic was changed in #1057, this broke AutoBone by causing the recorded trackers to be reset. This PR should fix the logic, though I'm not exactly sure what was intended by the logic. I've also added comments because it's not super readable.