Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tracker reset logic #1150

Merged
merged 3 commits into from
Sep 13, 2024
Merged

Fix tracker reset logic #1150

merged 3 commits into from
Sep 13, 2024

Conversation

ButterscotchV
Copy link
Member

The tracker reset logic was changed in #1057, this broke AutoBone by causing the recorded trackers to be reset. This PR should fix the logic, though I'm not exactly sure what was intended by the logic. I've also added comments because it's not super readable.

@ButterscotchV ButterscotchV added Type: Bug Something isn't working Priority: High Important feature or blocks something important Area: AutoBone The AutoBone feature Area: Server Related to the server labels Aug 28, 2024
Copy link
Member

@Erimelowo Erimelowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This’ll change behaviour. You should just set the Autobone trackers as internal if you don’t want them reset as that’s what they are

@ButterscotchV
Copy link
Member Author

This’ll change behaviour. You should just set the Autobone trackers as internal if you don’t want them reset as that’s what they are

If I set it to internal, then HumanSkeleton won't accept it. It's not internal anyways, that's not what that flag was supposed to mean. And why should the default behaviour be ignoring the needsReset flag?

@Erimelowo
Copy link
Member

IIRC it’s because the HMD has the needReset flag to false.
Would need to set that flag to true in the SteamVRDriver class and then there might be a condition to change in the resetHandler or HumanSkeleton.

Copy link
Member

@Erimelowo Erimelowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for old behaviour and Autobone seems to work (both tested)

@ImUrX ImUrX merged commit 1c867ef into SlimeVR:main Sep 13, 2024
8 checks passed
@ButterscotchV ButterscotchV deleted the tracker-logic branch September 13, 2024 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: AutoBone The AutoBone feature Area: Server Related to the server Priority: High Important feature or blocks something important Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants